diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e68ab51..084aaf1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -62,4 +62,4 @@ jobs: GH_TOKEN: ${{ github.token }} RELEASE_TAG: ${{ github.ref_name }} run: | - gh release create "$RELEASE_TAG" dist/*.zip dist/SHA256SUMS dist/QA-REPORT.json --draft --verify-tag --title "OpenBMH $RELEASE_TAG" --notes-file docs/release/1.0.11/RELEASE_NOTES.md + gh release create "$RELEASE_TAG" dist/*.zip dist/SHA256SUMS dist/QA-REPORT.json --draft --verify-tag --title "OpenBMH $RELEASE_TAG" --notes-file docs/release/1.0.12/RELEASE_NOTES.md diff --git a/CMakeLists.txt b/CMakeLists.txt index ebcec7c..2876508 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-3.0-only cmake_minimum_required(VERSION 3.24) -project(OpenBMH VERSION 1.0.11 LANGUAGES CXX C) +project(OpenBMH VERSION 1.0.12 LANGUAGES CXX C) if(APPLE) # Enable native languages before dependencies/subdirectories inherit rules. enable_language(OBJC OBJCXX) diff --git a/README.md b/README.md index a90c9ba..9514af4 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # OpenBMH -**Classic-Version: 1.0.11.** Die originalgetreue Linie bleibt in diesem Repository. +**Classic-Version: 1.0.12.** Die originalgetreue Linie bleibt in diesem Repository. Erweiterte Ligen, die gemeinsame deutsche/englische Karriere und der Dateneditor werden separat als **[OpenBMH-Extended 1.0 Beta](https://github.com/Weyoune/OpenBMH-extended)** entwickelt. @@ -30,7 +30,7 @@ In Windows PowerShell, use `.\OpenBMH.exe` and `.\openbmh_cli.exe` instead. To report a problem, start the game with `-debug`. It then writes `openbmh-debug.log` (timestamped events, errors and refused actions) and `openbmh-stderr.log` into the `debug` sub folder of the save directory, and saves the game there after every match day (`DBG00001.FBM`, `DBG00002.FBM`, ...). Attach the log and the last save to the report. -Use a writable save directory and keep backups of existing games. German editions are the primary compatibility target. **Football Limited / English data support is experimental**; original V2.20 save import and some edition-specific behaviour remain limited. See the [release notes](docs/release/1.0.11/RELEASE_NOTES.md). +Use a writable save directory and keep backups of existing games. German editions are the primary compatibility target. **Football Limited / English data support is experimental**; original V2.20 save import and some edition-specific behaviour remain limited. See the [release notes](docs/release/1.0.12/RELEASE_NOTES.md). ## Features and direction diff --git a/docs/release/1.0.12/RELEASE_NOTES.md b/docs/release/1.0.12/RELEASE_NOTES.md new file mode 100644 index 0000000..500fdae --- /dev/null +++ b/docs/release/1.0.12/RELEASE_NOTES.md @@ -0,0 +1,61 @@ +# OpenBMH Classic 1.0.12 + +This release makes the buttons of the dialogs behave like the original: a button +without a lasting state is drawn pressed while the mouse button is held. It also +carries everything of [1.0.11](../1.0.11/RELEASE_NOTES.md) (the game from asset +files plus `openbmh.dat`, the transfer market search, the poaching and selling +fixes). Extended development remains separate in +[OpenBMH-Extended](https://github.com/Weyoune/OpenBMH-extended). + +## Pressed buttons + +Many dialogs drew their buttons raised at all times, the original shows them +pressed for as long as the mouse button is down (the friendly match question +already did). Now pressed while held: + +- **Bank:** the two buttons of stocks, property, savings and credit, the OK of + its notices, Ja/Nein of the credit fee question and the keys of its calculator. +- **Spieler kaufen (offer editor):** Team-Info, Spieler-Info, Angebot, Abbruch and + the calculator keys. +- **Aufstellung:** Daten A/B and Spielfeld; **Spielfeld page:** Daten and Kurz + (the action starts after a short moment, as the pressed look has to be seen). +- **Contracts:** the buttons under the offer and the team premium panels + (Team-Prämien), OK of the answer and the calculator keys. +- **Advertising:** Abbrechen/Annehmen of an offer, OK of its notices and the keys of + its calculator. +- **Player card:** Schließen, Statistik and Zurück; **training camp:** the booking + button and OK; **file dialog:** Ja/Nein of the overwrite question and the page + button of a long list; **manager confirmation:** JA and NEIN; **transfer + decision:** OK of the confirmation. +- The notices that wait for any click (Sportschau, cup draw, game end screens) have + no button and are unchanged. Toggles that stay on (training, filters) keep their + lasting state. + +## Internal + +- The drawing of the wide push button, of the calculator window (panel and keys) and + of the dialog frame is now shared (`ui/button_frame.hpp`, + `ui/calculator_widgets.hpp`, `ui/dialog_frame.hpp`) instead of being copied in + about twenty dialogs. A test compares the shared drawing pixel for pixel with the + former one. A few buttons whose former drawing differs by one pixel (statistics + rankings, team statistics, opportunities, analytics) were left as they are. + +## Open points + +- The pressed look was checked by tests and by reading the drawing code, not yet + against a recording of the real Diamond 3.7; the exact timing of the short press on + the Spielfeld page is an estimate. +- **"Angebote prüfen" / listing again after a declined offer.** Could not be + reproduced; a debug log (`-debug`) or exact steps are still needed. +- The graphical client has not yet been tried with `openbmh.dat` and asset files only. +- The weekly processing, month changes and transfers are not yet compared with the + real 3.7 (only one matchday and the days after it were). +- Earlier open points remain: "player card: original atlas bounds" (#77), sporadic + double clicks (#58) and the macOS match scene speed (#70). + +## Known limits + +The compatibility and long-career limits documented for +[1.0.3](../1.0.3/RELEASE_NOTES.md) remain. Football Limited is experimental; +its original V2.20 save layout remains unsupported. Keep backups of saves. +macOS packages are unsigned terminal executables, not notarised app bundles.