diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 620b881..b4945e9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -62,4 +62,4 @@ jobs: GH_TOKEN: ${{ github.token }} RELEASE_TAG: ${{ github.ref_name }} run: | - gh release create "$RELEASE_TAG" dist/*.zip dist/SHA256SUMS dist/QA-REPORT.json --draft --verify-tag --title "OpenBMH $RELEASE_TAG" --notes-file docs/release/1.0/RELEASE_NOTES.md + gh release create "$RELEASE_TAG" dist/*.zip dist/SHA256SUMS dist/QA-REPORT.json --draft --verify-tag --title "OpenBMH $RELEASE_TAG" --notes-file docs/release/1.0.3/RELEASE_NOTES.md diff --git a/docs/DIFFERENCES.md b/docs/DIFFERENCES.md index ca8a619..5480f1d 100644 --- a/docs/DIFFERENCES.md +++ b/docs/DIFFERENCES.md @@ -6,25 +6,32 @@ See [Compatibility decisions](COMPATIBILITY.md) for the overall policy. These en describe deliberate changes; they are not a list of every known compatibility limit. - [src/app/career_session.cpp](../src/app/career_session.cpp): supports designated set-piece record initialization and validation. +- [src/app/main.cpp](../src/app/main.cpp): show only the static title until a complete left or right click, without the DOS loading animation. - [src/app/quit_confirmation.hpp](../src/app/quit_confirmation.hpp): confirms application exit with a localized native dialog, with cancellation selected by default. - [src/game/career.cpp](../src/game/career.cpp): skips reserved calendar positions when assigning a joining manager to a club. - [src/game/career.hpp](../src/game/career.hpp): uses the supported player-generation ranges and excludes reserved calendar positions when assigning managers. - [src/game/desk_actions.cpp](../src/game/desk_actions.cpp): uses the supported transfer-fee arithmetic and designated set-piece fields. - [src/game/desk_actions.hpp](../src/game/desk_actions.hpp): supports designated set-piece records and the supported transfer-editor rules. +- [src/game/desk_actions.hpp](../src/game/desk_actions.hpp): a seller may accept an existing bid before expiry. - [src/game/highscore.cpp](../src/game/highscore.cpp): reads the supported edition-specific high-score format from the loaded image. - [src/game/lineup.hpp](../src/game/lineup.hpp): supports owner-bound designated set-piece selection. - [src/game/match.hpp](../src/game/match.hpp): uses the enhanced injury selection and suspension rules. - [src/game/match_engine.cpp](../src/game/match_engine.cpp): supports designated set-piece takers, the enhanced injury tables, and the extended suspension fields. +- [src/game/month.cpp](../src/game/month.cpp): keep the price product in 64 bits until division, retaining per-unit truncation and recipient policy. +- [src/game/national.cpp](../src/game/national.cpp): a new arrival must not inherit the previous occupant's retirement/refusal/month-processing flags. - [src/game/season.cpp](../src/game/season.cpp): retains the enhanced academy player-generation strength bands with monthly youth budgets. - [src/game/season.cpp](../src/game/season.cpp): age/retire each player once, even when a temporary offer row references his club slot or regeneration moves him to a later free-agent slot. - [src/game/season.cpp](../src/game/season.cpp): includes transfer-market players in retirement so the five-bit age cannot wrap to 16. - [src/game/season.cpp](../src/game/season.cpp): initializes the empty EM qualifier seeds with national teams, preventing club zero from entering the EM. - [src/game/season.hpp](../src/game/season.hpp): retains the enhanced academy player-generation strength bands with monthly youth budgets. - [src/game/state.hpp](../src/game/state.hpp): retains designated set-piece selections in the supported manager-record extension. +- [src/game/week.cpp](../src/game/week.cpp): widen products before annual-rate division so valid native account amounts do not overflow intermediate sums. +- [src/game/week.cpp](../src/game/week.cpp): an unknown history receives a grace month; later losses occur at most once per source month. - [src/game/week.cpp](../src/game/week.cpp): uses the enhanced training rules: focus strength is at least five below its target, and completed skills rotate to another focus. - [src/game/week.hpp](../src/game/week.hpp): uses the enhanced assistant-training rules, retaining the selected skill until it reaches its maximum. - [src/game/weekly.cpp](../src/game/weekly.cpp): uses the supported weekly-event configuration, with its rule switch disabled. - [src/game/weekly.hpp](../src/game/weekly.hpp): uses the supported weekly processing and transfer rule profile. +- [src/ui/bank.cpp](../src/ui/bank.cpp): read-only totals use wide arithmetic; individual saved account, price, holding and paid fields are unchanged. - [src/ui/league_table.hpp](../src/ui/league_table.hpp): uses three points for a win in the supported rule profile. - [src/ui/pitch.cpp](../src/ui/pitch.cpp): supports owner-bound designated set-piece selection in the extended manager record. - [src/ui/save_load.cpp](../src/ui/save_load.cpp): focuses the host save filename on entry and selects an existing name for replacement. diff --git a/docs/release/1.0.3/RELEASE_NOTES.md b/docs/release/1.0.3/RELEASE_NOTES.md new file mode 100644 index 0000000..c011aa6 --- /dev/null +++ b/docs/release/1.0.3/RELEASE_NOTES.md @@ -0,0 +1,38 @@ +# OpenBMH Classic 1.0.3 + +Release candidate. Platform package and integrated QA results will be recorded +before publication. Extended development lives separately in +[OpenBMH-Extended](https://github.com/Weyoune/OpenBMH-extended). + +Changes under verification: + +- Football Limited date setup and prepared-image cache; case-insensitive paths + for Original CD data. +- A static Original title with its own palette, no loading balls, and a complete + left/right click to enter setup. +- Ordinary dialogs preserve the scene behind them. +- Scores remain at the previous result during goal scenes and update at reveal. +- A complete right-button release belongs to the dismissed table/overview. +- Original preferred-position swatches and colored pitch cursor are restored. +- Own transfer listings expose existing offers early. Viewing/canceling does not + alter the listing. Failed or refused listings can be listed again. +- Fresh arrivals do not inherit a previous occupant's contract-refusal flags. +- Saved wide player counters and title archives outlive native counter/window + boundaries; old lost history cannot be reconstructed. +- Interest/dividend intermediate arithmetic and Bank aggregate display use wide + values. Individual native account fields still have their documented limits. +- Bank robbery remains at the original threshold/amount but occurs at most once + per manager and calendar month, with a saved latch. An unknown older history + receives a grace month to avoid another deduction just after upgrading. +- Standard stadium blocks can reach144,000 places with edition-owned unit prices + and size-aware build periods. Existing saves retain their native capacity bytes. + +Known limits: + +Calendar and rescheduling opened in the verified Classic datasets; the reported +failure remains an open Human-QA item. Some supplied saves (including a supplied +Diamond3.7 autosave) are rejected as damaged/unsupported before gameplay and are +not claimed repaired by unrelated transfer fixes. Histories are preserved only +from information available when this version starts. Older programs can discard +OpenBMH's optional save extensions. True multi-billion single-account storage +and every corresponding financial writer remain a separate unresolved issue. diff --git a/tests/stadium_block_app_tests.cpp b/tests/stadium_block_app_tests.cpp index bb21217..4f34b17 100644 --- a/tests/stadium_block_app_tests.cpp +++ b/tests/stadium_block_app_tests.cpp @@ -589,12 +589,7 @@ void test_yes_level_zero_and_funds_refusal(const std::filesystem::path& data) { resolve_stand_block_offer(accepted,true,expected_random); GameState expected=session->state(); auto exe=load_le(ui::asset_path(data,"BMH.exe")); - StadiumBlockExpansionConstants constants; - for(unsigned i=0;i<8;++i) { - constants.price_per_1000[i]=exe.u32(::bmh::layout::CareerSession_DispatchStadium_RuntimeField+(i+8)*4); - constants.weeks[i]=exe.u8(::bmh::layout::CareerSession_DispatchStadium_RuntimeField2+(i+22)*5); - constants.max_places[i]=uint32_t(exe.u8(::bmh::layout::CareerSession_Invalid_RuntimeField+i))*1000; - } + const auto constants=stadium_block_expansion_constants(exe); check(build_stadium_block_expansion(expected,manager,StadiumBlockSlot::B,constants, quote,accepted,expected_random),"independent Source Engine simulation accepts YES at level 0"); const auto game_before=session->game(); diff --git a/tests/stadium_extended_limits_tests.cpp b/tests/stadium_extended_limits_tests.cpp index 51e7707..880e55a 100644 --- a/tests/stadium_extended_limits_tests.cpp +++ b/tests/stadium_extended_limits_tests.cpp @@ -9,7 +9,7 @@ void check(bool value,const char* message){if(!value)throw std::runtime_error(me } int main()try{ using namespace bmh; - auto image=LeImage::from_bytes(0xa3600,Bytes(0x1000)); + auto image=LeImage::from_bytes(layout::GermanDataSegmentBegin,Bytes(0x3000)); const uint8_t original_max[]={8,18,8,14,8,18,8,14},original_weeks[]={30,37,30,25,30,37,30,25}; for(uint32_t i=0;i<8;++i){image.patch(layout::CareerSession_Invalid_RuntimeField+i,original_max+i,1);image.patch(layout::CareerSession_DispatchStadium_RuntimeField2+(i+22)*5,original_weeks+i,1);const uint8_t price[]={0xe0,0x93,0x04,0};image.patch(layout::CareerSession_DispatchStadium_RuntimeField+(i+8)*4,price,4);} const auto constants=stadium_block_expansion_constants(image);