From 1e7df751a0b9a549028990a9f2f9cfca0e15015d Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 4 Nov 2026 20:44:58 +0100 Subject: [PATCH] Describe original routines in comments instead of naming them The public-source check rejects decompiler symbol names. Co-Authored-By: Claude Sonnet 5.5 --- src/app/main.cpp | 2 +- src/ui/training.cpp | 2 +- src/ui/training.hpp | 2 +- src/ui/training_tests.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/main.cpp b/src/app/main.cpp index d383435..29a4977 100644 --- a/src/app/main.cpp +++ b/src/app/main.cpp @@ -230,7 +230,7 @@ int main(int argc, char** argv) { english_game = english_game || season_exe.u8(layout::LeagueSizes) == 20; { // The pointer of the original is its default 11x11 bitmap (index 0 transparent, hot spot - // top left, set by the window objects' FUN_000559eb); the pitch page draws the same bitmap + // top left, set when a window object is created); the pitch page draws the same bitmap // with its own fill colour. The edition's own bitmap is used for the English version. std::array bitmap{}; for (uint32_t i = 0; i < bitmap.size(); ++i) { diff --git a/src/ui/training.cpp b/src/ui/training.cpp index 6fde9e6..bec39d4 100644 --- a/src/ui/training.cpp +++ b/src/ui/training.cpp @@ -250,7 +250,7 @@ Image TrainingScreen::render() const { } rect(out, 190, 222, 66, 6, 0x44); text(out, 190, 220, texts_[(::bmh::layout::Training_Render_TextPointer4 - ::bmh::layout::TextPointerTable) / 4], 0x51, -1, false); - // FUN_00049399: seven bars, one per skill (two bits each of the player's skill word); each + // The original's skill display: seven bars, one per skill (two bits each of the player's skill word); each // takes the atlas tile of its level 0-3, all empty while no player's row is under the pointer. const auto hovered = hovered_row_ ? std::find_if(state_.players.begin(), state_.players.end(), [&](const auto& p) { return p.row == *hovered_row_; }) diff --git a/src/ui/training.hpp b/src/ui/training.hpp index f4f8d3c..b2aeaf6 100644 --- a/src/ui/training.hpp +++ b/src/ui/training.hpp @@ -54,7 +54,7 @@ public: Image render() const; TrainingRequest click(int x, int y, bool right = false); TrainingRequest key(std::string_view key); - // Original FUN_00049399: while the pointer rests on a player's row of the training list, the + // The original's skill display: while the pointer rests on a player's row of the training list, the // seven skill bars (T S S P Z F E) at the bottom show that player's skills; leaving it clears them. bool move(int x, int y); // Opening an uninitialized original screen invokes Initialize. This diff --git a/src/ui/training_tests.cpp b/src/ui/training_tests.cpp index ee024cc..da5dd7e 100644 --- a/src/ui/training_tests.cpp +++ b/src/ui/training_tests.cpp @@ -67,7 +67,7 @@ int main(int argc, char** argv) { TrainingScreen screen(data, s); const auto frame = screen.render().pixels; check(frame == screen.render().pixels, "repeat rendering is deterministic and pure"); { - // FUN_00049399: the seven skill bars follow the player row under the pointer + // the seven skill bars follow the player row under the pointer const int bx = exe.u16(::bmh::layout::Training_Click_RuntimeField + 6), by = exe.u8(::bmh::layout::Training_Click_RuntimeField3 + 3); const int dy = exe.u8(::bmh::layout::Training_Click_RuntimeField9 + 3); TrainingScreen hover(data, s);