diff --git a/README.md b/README.md index 5e9e986..6e0f217 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # OpenBMH -The separate [OpenBMH Editor 0.5.4](docs/EDITOR.md) uses native RmlUI, +The separate [OpenBMH Editor 0.5.5](docs/EDITOR.md) uses native RmlUI, supports German/English, three themes, image editing and a local MCP server. -Download its own `editor-v0.5.4` release or build with +Download its own `editor-v0.5.5` release or build with `-DOPENBMH_BUILD_EDITOR=ON`. Edited worlds are independent of the Classic runtime. A modern and faithful open source rebuild of the *Bundesliga Manager Hattrick* engine. diff --git a/assets/editor/theme.rcss b/assets/editor/theme.rcss index 3434043..a3e0d59 100644 --- a/assets/editor/theme.rcss +++ b/assets/editor/theme.rcss @@ -166,7 +166,9 @@ input[type=range] bar { width: 16dp; height: 16dp; border-radius: 8dp; backgroun select { padding-right: 30dp; cursor: pointer; background-color: transparent; decorator: linear-gradient(var(--control-top), var(--control-bottom)); box-shadow: inset 0 1dp #eff6fc12, 0 1dp 2dp #0002; } select:hover { background-color: var(--hover); decorator: none; } select selectvalue { padding: 0; } -select selectarrow { width: 8dp; height: 8dp; margin-right: 13dp; margin-top: 11dp; decorator: none; border-bottom: 1.5dp var(--muted); border-right: 1.5dp var(--muted); transform: rotate(45deg); } +/* RmlUI anchors the arrow to the content box. Use the reserved right padding + and center the rotated glyph within the control's 18dp content height. */ +select selectarrow { width: 8dp; height: 8dp; margin-right: -15dp; margin-top: 3dp; decorator: none; border-bottom: 1.5dp var(--muted); border-right: 1.5dp var(--muted); transform: rotate(45deg); } select selectbox { width: 100%; min-width: 180dp; background-color: var(--popup); color: var(--text); border: 1dp var(--border); border-radius: 9dp; padding: 5dp; margin-top: 7dp; margin-bottom: 7dp; max-height: 320dp; overflow-y: auto; box-shadow: 0 9dp 28dp #0008; } select option { display: flex; align-items: center; min-height: 34dp; padding: 5dp 7dp; border-radius: 5dp; white-space: nowrap; cursor: pointer; } select option:hover { background-color: var(--hover); } diff --git a/docs/EDITOR.md b/docs/EDITOR.md index 521c015..68a9174 100644 --- a/docs/EDITOR.md +++ b/docs/EDITOR.md @@ -1,6 +1,6 @@ -# OpenBMH Editor 0.5.4 +# OpenBMH Editor 0.5.5 -Der eigenständige, native Editor verwendet **RmlUI und SDL2**, unter Windows mit Direct3D 11, unter Linux/macOS mit OpenGL. Er bearbeitet Startdatenbanken, keine laufenden Spielstände. Das Spiel und seine Classic-Prüfung bleiben unverändert. Editor 0.5.4 hat eine eigene Versionsreihe und den Release-Tag `editor-v0.5.4`; die Spielversion ist 0.2.1. +Der eigenständige, native Editor verwendet **RmlUI und SDL2**, unter Windows mit Direct3D 11, unter Linux/macOS mit OpenGL. Er bearbeitet Startdatenbanken, keine laufenden Spielstände. Das Spiel und seine Classic-Prüfung bleiben unverändert. Editor 0.5.5 hat eine eigene Versionsreihe und den Release-Tag `editor-v0.5.5`; die Spielversion ist 0.2.1. ## Windows-Start und Diagnose @@ -17,7 +17,7 @@ MCP-Aufrufe zeigen keinen modalen Fehlerdialog und behalten ihre Prozesscodes. ## Starten und Daten öffnen -Das vollständige Paket `OpenBMHEditor-0.5.4-.zip` entpacken und `OpenBMHEditor.exe` (Windows) beziehungsweise `OpenBMHEditor` (Linux/macOS) starten. `assets/editor` muss beim Programm bleiben. Auf macOS kann die unsignierte Anwendung über **Rechtsklick → Öffnen** gestartet werden. Eine Signatur/Notarisierung ist nicht Bestandteil dieser Version. `OpenBMHEditor --version` zeigt die Editorversion ohne Grafikstart. +Das vollständige Paket `OpenBMHEditor-0.5.5-.zip` entpacken und `OpenBMHEditor.exe` (Windows) beziehungsweise `OpenBMHEditor` (Linux/macOS) starten. `assets/editor` muss beim Programm bleiben. Auf macOS kann die unsignierte Anwendung über **Rechtsklick → Öffnen** gestartet werden. Eine Signatur/Notarisierung ist nicht Bestandteil dieser Version. `OpenBMHEditor --version` zeigt die Editorversion ohne Grafikstart. **Öffnen** bietet OBW-Dateien und entpackte Welten an. **BMH / FLTD importieren** liest einen Ordner mit einer unterstützten BMH- oder Football-Limited-Installation durch den bestehenden Konverter. Das Original wird nicht überschrieben. Eine bestehende Classic-OBW wird zunächst überprüft und dann in eine bearbeitbare Editorwelt übernommen. @@ -168,4 +168,4 @@ Click a crest, portrait, trophy or list thumbnail to open a large read-only imag In **Options**, switch the interface to **English**, choose one of the three themes, and enable/disable the integrated local MCP server. **Copy connection** provides the authenticated configuration. The server defaults to loopback port 8765; use port 0 for a free port. GUI and MCP share the same world, validation and undo history. It supports MCP Streamable HTTP 2025-11-25/2025-06-18 and optional stdio mode. Use `expected_revision` for concurrent edits. -Build with the three commands above, including `-DOPENBMH_BUILD_EDITOR=ON`. Windows uses Direct3D 11 with automatic WARP software fallback. Linux requires OpenGL 3.3; macOS requires OpenGL 4.1, plus the documented platform development dependencies. Editor 0.5.4 is unsigned and does not bundle any real-world dataset or proprietary game assets. +Build with the three commands above, including `-DOPENBMH_BUILD_EDITOR=ON`. Windows uses Direct3D 11 with automatic WARP software fallback. Linux requires OpenGL 3.3; macOS requires OpenGL 4.1, plus the documented platform development dependencies. Editor 0.5.5 is unsigned and does not bundle any real-world dataset or proprietary game assets. diff --git a/docs/qa/editor-dropdown-arrow/README.md b/docs/qa/editor-dropdown-arrow/README.md new file mode 100644 index 0000000..5dc9100 --- /dev/null +++ b/docs/qa/editor-dropdown-arrow/README.md @@ -0,0 +1,31 @@ +# Dropdown chevron alignment — Editor 0.5.5 + +The old chevron was too low and too far inside the button. RmlUI positions its +native `selectarrow` from the select's content box, which already excludes the +reserved right padding. The correction moves the existing glyph 28dp right and +8dp up, into that padding and onto the control's vertical center. Size, colour, +selected values and native select events stay the same. + +These are actual SDL2/RmlUI captures with software OpenGL. All data comes from +`OpenBMHEditor --demo --page clubs`: generated clubs and project-authored +geometric crests. No original installation or savegame is involved. Temporary +MCP profiles use an automatically assigned localhost port; no token is visible +or included. Images are captured directly, without image generation or retouching. + +| View | Native capture | +|---|---| +| Before: 0.5.4, Midnight / German | [Before](before-0.5.4.png) | +| After: 0.5.5, Midnight / German | [After](after-midnight-1440x900.png) | +| After: Silver / English | [Silver](after-silver-1440x900.png) | +| After: Matchday / German | [Matchday](after-matchday-1440x900.png) | +| Toolbar and inspector controls | [Main view](after-toolbar.png) | +| Click directly on the repositioned theme arrow | [Native open list](after-dropdown.png) | +| Small window, 1080×720, editor scale 0.78× | [Small](after-midnight-1080x720.png) | +| Large window, 2560×1600, editor scale 1.78× | [Large](after-midnight-2560x1600.png) | + +[Capture parameters](native-captures.json) record the themes, languages, native +viewports and editor scales. The arrow remains inside the button at each scale. +Clicking its new position opens the native option list; Escape dismisses it. +The existing native GUI smoke verifies selection changes, all themes, both +languages, draft protection and navigation. This layout-only correction adds +no editor data or engine behaviour. diff --git a/docs/qa/editor-dropdown-arrow/after-dropdown.png b/docs/qa/editor-dropdown-arrow/after-dropdown.png new file mode 100644 index 0000000..73d0aa4 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-dropdown.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-matchday-1440x900.png b/docs/qa/editor-dropdown-arrow/after-matchday-1440x900.png new file mode 100644 index 0000000..3add4a5 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-matchday-1440x900.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-midnight-1080x720.png b/docs/qa/editor-dropdown-arrow/after-midnight-1080x720.png new file mode 100644 index 0000000..e2b1747 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-midnight-1080x720.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-midnight-1440x900.png b/docs/qa/editor-dropdown-arrow/after-midnight-1440x900.png new file mode 100644 index 0000000..eb31edf Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-midnight-1440x900.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-midnight-2560x1600.png b/docs/qa/editor-dropdown-arrow/after-midnight-2560x1600.png new file mode 100644 index 0000000..d20d937 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-midnight-2560x1600.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-silver-1440x900.png b/docs/qa/editor-dropdown-arrow/after-silver-1440x900.png new file mode 100644 index 0000000..dea0895 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-silver-1440x900.png differ diff --git a/docs/qa/editor-dropdown-arrow/after-toolbar.png b/docs/qa/editor-dropdown-arrow/after-toolbar.png new file mode 100644 index 0000000..b4e0cdb Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/after-toolbar.png differ diff --git a/docs/qa/editor-dropdown-arrow/before-0.5.4.png b/docs/qa/editor-dropdown-arrow/before-0.5.4.png new file mode 100644 index 0000000..7712944 Binary files /dev/null and b/docs/qa/editor-dropdown-arrow/before-0.5.4.png differ diff --git a/docs/qa/editor-dropdown-arrow/native-captures.json b/docs/qa/editor-dropdown-arrow/native-captures.json new file mode 100644 index 0000000..d11f84b --- /dev/null +++ b/docs/qa/editor-dropdown-arrow/native-captures.json @@ -0,0 +1,60 @@ +{ + "editor": "0.5.5", + "cases": [ + { + "theme": "midnight", + "language": "de", + "viewport": [ + 1440, + 900 + ], + "scale": 1.0, + "data": "generated demo", + "capture": "after-midnight-1440x900.png" + }, + { + "theme": "silver", + "language": "en", + "viewport": [ + 1440, + 900 + ], + "scale": 1.0, + "data": "generated demo", + "capture": "after-silver-1440x900.png" + }, + { + "theme": "matchday", + "language": "de", + "viewport": [ + 1440, + 900 + ], + "scale": 1.0, + "data": "generated demo", + "capture": "after-matchday-1440x900.png" + }, + { + "theme": "midnight", + "language": "de", + "viewport": [ + 1080, + 720 + ], + "scale": 0.78, + "data": "generated demo", + "capture": "after-midnight-1080x720.png" + }, + { + "theme": "midnight", + "language": "de", + "viewport": [ + 2560, + 1600 + ], + "scale": 1.7777777777777777, + "data": "generated demo", + "capture": "after-midnight-2560x1600.png" + } + ] +} diff --git a/docs/release/editor-0.5/RELEASE_NOTES.md b/docs/release/editor-0.5/RELEASE_NOTES.md index 83b2dae..af4bd4b 100644 --- a/docs/release/editor-0.5/RELEASE_NOTES.md +++ b/docs/release/editor-0.5/RELEASE_NOTES.md @@ -1,5 +1,13 @@ -# OpenBMH Editor 0.5.4 +# OpenBMH Editor 0.5.5 + +Centers the dropdown chevron vertically and moves it into the reserved right +padding. This fixes its low, inset position in toolbar filters, inspectors and +Options across all three themes and editor scales. Native select behavior is +preserved. [Before/after native captures](../../qa/editor-dropdown-arrow/README.md) +use synthetic data. + +## Editor 0.5.4 Adds browser-style **Back / Forward** navigation. Right-click anywhere in the editor to open the context menu; Alt+Left/Right and mouse side buttons use the diff --git a/src/editor/CMakeLists.txt b/src/editor/CMakeLists.txt index 46ece69..5be1b6a 100644 --- a/src/editor/CMakeLists.txt +++ b/src/editor/CMakeLists.txt @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-3.0-only include(FetchContent) -set(OPENBMH_EDITOR_VERSION "0.5.4") +set(OPENBMH_EDITOR_VERSION "0.5.5") file(WRITE "${CMAKE_BINARY_DIR}/editor-version.json" "{\"version\": \"${OPENBMH_EDITOR_VERSION}\"}\n") set(JSON_BuildTests OFF CACHE BOOL "" FORCE) FetchContent_Declare(editor_json GIT_REPOSITORY https://github.com/nlohmann/json.git diff --git a/tools/public_release/check_public_tree.py b/tools/public_release/check_public_tree.py index 4922e0b..c87d284 100644 --- a/tools/public_release/check_public_tree.py +++ b/tools/public_release/check_public_tree.py @@ -45,6 +45,30 @@ SKIP_DIRECTORIES = {".git", "__pycache__", ".cache", "_deps", "node_modules"} # The latter are reviewed against docs/qa/editor-poc/README.md; no game material. # Keep prior reviewed hashes if an asset is intentionally revised in history. PROJECT_ARTWORK = { + "docs/qa/editor-dropdown-arrow/after-dropdown.png": { + "5c89970a44ee114e5cf65b38d7972493fbc3ed125ff7a0e83c86a05b8a66be06", + }, + "docs/qa/editor-dropdown-arrow/after-matchday-1440x900.png": { + "c92fcdce42ea9b34e6e149e36ff49af57d15d863c0455fbd41dce0807d59d29b", + }, + "docs/qa/editor-dropdown-arrow/after-midnight-1080x720.png": { + "b32c186f678a11c1f7da13cbaed22ebcadf12fa6f1bd41c248b2d63a73a5bd3e", + }, + "docs/qa/editor-dropdown-arrow/after-midnight-1440x900.png": { + "ae8d8790e4c00ab09b98b1f1e3f1e22acd6a8103bf5104c4e0d690d6bf1cdcfd", + }, + "docs/qa/editor-dropdown-arrow/after-midnight-2560x1600.png": { + "67283d8a4e9be4f779ef1482016059febbb6be7d94242b074bbafa6f1ce5e18f", + }, + "docs/qa/editor-dropdown-arrow/after-silver-1440x900.png": { + "ea6ee3852468ff684362fcc65b06fff0a1bcccd0190673185620e36b03f8dc6e", + }, + "docs/qa/editor-dropdown-arrow/after-toolbar.png": { + "ca1db2ddc6a4b764c9715f9f17c5d370906eb6668c7a0770f0d674efd5724a96", + }, + "docs/qa/editor-dropdown-arrow/before-0.5.4.png": { + "d642c323a4601d167c4b8f5f24549332889215de1dc98ff929f2beb9f5d69eaa", + }, "docs/qa/editor-navigation/before-options-0.5.3.png": { "493984e53b85c516a3a541ae879fdd18fdc7ec54a4d6478c571865bee15a9b44", },