Prepare Classic 1.0 edition rules and Diamond 3.7 foreign crests (by Codex)
This commit is contained in:
1 parent
c293a35f56
commit
8ee062ea46
46 files changed
+296
-147
No files matched your search
+12
-21
@@ -2,7 +2,7 @@
|
||||
|
||||
OpenBMH aims to preserve the familiar game while handling malformed input and unsafe edge cases explicitly. A reconstruction can remain faithful without reproducing a crash or pretending to implement an unknown path.
|
||||
|
||||
- Content such as names, text, graphics and edition-specific tables is loaded from the user's installation. OpenBMH's shared rule base supplies simulation values; selecting another data edition does not select a separate engine.
|
||||
- Content such as names, text, graphics and edition-specific tables is loaded from the user's installation. The loaded program retains its own rule-table values; loading no longer applies the former shared replacement profile.
|
||||
- Safety checks reject transactions that would exhaust required return capacity, use stale identities or lose a valid state. Unsupported operations report their limitation rather than inventing an outcome.
|
||||
- Calendar progression handles boundary days and seasonal transitions without relying on unsafe fixed-day assumptions.
|
||||
- Saves are written from the committed session state. Saving does not deliberately replay unrelated game actions.
|
||||
@@ -23,26 +23,17 @@ An unavailable native message box also cancels the request. This applies to
|
||||
voluntary application exits, including quit events received during animations;
|
||||
normal completed-career handling remains separate.
|
||||
|
||||
## Environment and presentation in 0.1.2
|
||||
## Original edition rules in 1.0
|
||||
|
||||
The desktop environment provides three youth teams and three staff
|
||||
budgets, each set to zero through six stars. Youth budgets are monthly, can be
|
||||
changed throughout the season, and contribute to the finance preview, balance
|
||||
plan and booked expenses. Youth tables develop on first-division matchdays;
|
||||
promotion, relegation and age-group handover occur at the season change.
|
||||
The two previously hidden youth groups are available across data editions.
|
||||
Staff prices and the shared academy player-generation strength bands stay in
|
||||
effect. Recruitment needs an active middle youth budget and an oldest youth team
|
||||
within 25 strength points of the senior squad (the full-build mode bypasses the
|
||||
strength gate). This deliberately
|
||||
combines the six-budget environment with OpenBMH's existing player-generation rules.
|
||||
Loaded executable images are not rewritten to the former shared rule profile. Career strength ranges are read from all nine pairs of the original table. Normalized simulation values from 0.2/NextGen are not backported.
|
||||
|
||||
Old saved academy lump sums remain payable once and retain their paid status.
|
||||
They are not multiplied into twelve monthly payments. Editing that tile replaces
|
||||
the old amount with the selected monthly budget. There is no new save field.
|
||||
The six-budget monthly environment implementation has been checked against the provided CD and Diamond 3.6/3.7 program code. Its budget increments are read from that program's own table. Capability recognition uses verified code fingerprints, never directory names. Unrecognized environment implementations cannot be edited or simulated through a guessed model; they require separate compatibility verification. Older Diamond academy patches are not silently treated as the monthly model. The old floppy executable remains unsupported, and Football Limited remains experimental.
|
||||
|
||||
Live match minutes use the loaded original delay setting (A9), including zero,
|
||||
instead of an added fixed pause. A9 and the existing scene delays can be adjusted
|
||||
in Settings; loaded saves and EIN files retain their chosen speeds. VGA retrace
|
||||
animations use a 70-Hz reference instead of the host monitor's refresh rate.
|
||||
`--live-frame-ms` and `BMH_LIVE_FRAME_MS` remain explicit diagnostic overrides.
|
||||
Release acceptance of individual editions is recorded separately from their recognition. Source compatibility and automated tests do not establish full original-game or platform validation.
|
||||
|
||||
## Diamond 3.7 foreign crests
|
||||
|
||||
The supplied edition controls whether foreign league clubs use individual
|
||||
original crests or the original neutral crest. OpenBMH recognizes the verified
|
||||
Diamond 3.7 drawing gate and uses its database/save selectors and W atlases.
|
||||
Older drawing gates retain their own behaviour; no external crest pack is needed.
|
||||
@@ -7,14 +7,10 @@ describe deliberate changes; they are not a list of every known compatibility li
|
||||
|
||||
- [src/app/career_session.cpp](../src/app/career_session.cpp): supports designated set-piece record initialization and validation.
|
||||
- [src/app/quit_confirmation.hpp](../src/app/quit_confirmation.hpp): confirms application exit with a localized native dialog, with cancellation selected by default.
|
||||
- [src/formats/le.hpp](../src/formats/le.hpp): applies a shared supported rule profile when loading editions with different rule-table values.
|
||||
- [src/formats/rule_base.cpp](../src/formats/rule_base.cpp): normalizes live-scene defaults, league strength ranges, option defaults, stadium prices and capacities, betting limits, and the foreign-player limit across supported editions.
|
||||
- [src/formats/rule_base.hpp](../src/formats/rule_base.hpp): normalizes live-scene options, league strength ranges, option defaults, stadium prices and capacities, betting limits, and the foreign-player limit.
|
||||
- [src/game/career.cpp](../src/game/career.cpp): skips reserved calendar positions when assigning a joining manager to a club.
|
||||
- [src/game/career.hpp](../src/game/career.hpp): uses the supported player-generation ranges and excludes reserved calendar positions when assigning managers.
|
||||
- [src/game/desk_actions.cpp](../src/game/desk_actions.cpp): uses the supported transfer-fee arithmetic and designated set-piece fields.
|
||||
- [src/game/desk_actions.hpp](../src/game/desk_actions.hpp): supports designated set-piece records and the supported transfer-editor rules.
|
||||
- [src/game/environment.hpp](../src/game/environment.hpp): uses six monthly environment budgets across data editions while retaining the shared staff prices and academy player-generation strength bands.
|
||||
- [src/game/highscore.cpp](../src/game/highscore.cpp): reads the supported edition-specific high-score format from the loaded image.
|
||||
- [src/game/lineup.cpp](../src/game/lineup.cpp): disables the foreign-player limit in the supported rule profile.
|
||||
- [src/game/lineup.hpp](../src/game/lineup.hpp): disables the foreign-player limit and supports owner-bound designated set-piece selection.
|
||||
|
||||
@@ -19,7 +19,7 @@ OpenBMH reconstructs the Bundesliga Manager Hattrick engine in C++20. The graphi
|
||||
- Setup ignores mouse releases without a matching press on that screen, so
|
||||
window activation cannot toggle the initial league/national-team selection
|
||||
through that input path ([#10](https://github.com/Weyoune/openbmh/issues/10)).
|
||||
- Source builds include the standalone [OBW installation converter](../../formats/obw/import.md).
|
||||
- Source builds include the standalone [OBW installation converter](https://github.com/Weyoune/openbmh/blob/v0.2.1/docs/formats/obw/import.md).
|
||||
It produces intermediate database conversions; game integration remains
|
||||
planned for 0.2.
|
||||
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
# Classic 1.0 backport audit
|
||||
|
||||
Baseline: v0.1.2. The release branch keeps the existing public history; the baseline restoration is an ordinary commit, not a force reset of main.
|
||||
|
||||
| Later change | Decision |
|
||||
|---|---|
|
||||
| 8326a23: host filenames/path display, setup input guards | Included; direct-installation code, no launcher/converter dependency |
|
||||
| e1d17d8: explicit quit confirmation | Included; cancellation preserves current owner/state |
|
||||
| c8f04d0: reschedule undo replay bit | Included; restores original target-day availability |
|
||||
| b879d5b: standalone original message texts | Included as a focused adaptation; no native-content dependency |
|
||||
| 978a014: edition-specific restored match-group expansion | Pending compatibility verification; no OBW save changes will be taken |
|
||||
| 0b2354c: native file flows and English media | OBW paths excluded; applicable legacy filename correction reviewed separately |
|
||||
| 856d38c / 500354c: RmlUI/WARP startup | Not applicable to the restored SDL Classic application; do not bring back RmlUI |
|
||||
| 0.3 Modern manager placement correction | Excluded; belongs to Dreierpack Manager, not faithful Classic behaviour |
|
||||
|
||||
Version 1.0 no longer rewrites loaded rule tables to a shared profile. Original strength ranges and environment price steps are installed from the supplied edition. Environment implementations outside verified program fingerprints remain unverified, never silently enabled by a directory name.
|
||||
|
||||
This is an implementation audit, not a completed release acceptance report. Original-data, GUI, save compatibility and platform results must be recorded before the final tag.
|
||||
|
||||
## Diamond 3.7 foreign crests
|
||||
|
||||
The drawing policy is installed from the verified gate in the supplied executable.
|
||||
Diamond 3.7 uses individual original W-sheet cells for the 48 foreign league clubs.
|
||||
Earlier verified editions retain their neutral foreign-club crest. Database and
|
||||
savegame selectors remain authoritative, including after club movement; no
|
||||
high-resolution replacement pack or changed competition structure is required.
|
||||
Unknown drawing gates retain the conservative legacy policy. National teams,
|
||||
non-rostered clubs and missing-club tokens retain their existing treatment.
|
||||
|
||||
Private data verification decoded all 48 Diamond 3.7 selections and checked their
|
||||
38-pixel cells against atlas bounds. This is an asset-path/contact-sheet check,
|
||||
not a claim of completed interactive GUI acceptance.
|
||||
|
||||
## Author-supplied defect reference
|
||||
|
||||
The Diamond author supplied a private reference catalogue covering 33 original
|
||||
bug corrections. The supplied original executable hash and all 1,084 documented
|
||||
byte changes were independently checked against local original/Diamond files.
|
||||
The archive and disassembly remain outside this public repository. Binary patch
|
||||
caves are evidence of the old defect, not an implementation requirement.
|
||||
|
||||
Initial source review finds corrected camp field packing and separated card
|
||||
save-back contexts already present. Their dedicated regression acceptance is
|
||||
still pending. Retirement handling still excludes transfer-market slots and
|
||||
requires correction. The complete 33-item review is tracked privately; none of
|
||||
the unreviewed entries is claimed complete.
|
||||
@@ -0,0 +1,9 @@
|
||||
# OpenBMH 1.0 release candidate
|
||||
|
||||
Classic direct-installation runtime restored from v0.1.2. No launcher, converter, OBW runtime or Modern UI. The game executable is OpenBMH / OpenBMH.exe; openbmh_cli remains available.
|
||||
|
||||
Reviewed backports include host filename/path handling, explicit quit confirmation, original message text installation in standalone tools, and clearing the calendar replay flag after undoing a reschedule. German CD-compatible BMH and verified Diamond editions are the release targets. Football Limited remains experimental; the old floppy executable is unsupported.
|
||||
|
||||
This candidate is under compatibility validation, especially edition-dependent rules and environment behaviour. No complete platform or original-game acceptance is claimed before its recorded tests pass. Existing 0.2/editor releases remain historical; NextGen development moves to Dreierpack Manager.
|
||||
|
||||
Diamond 3.7 foreign league crests use the supplied edition's original drawing gate, database selectors and W sheets. Older editions retain their original neutral foreign-club crest.
|
||||
@@ -0,0 +1,13 @@
|
||||
# Classic 1.0 candidate validation
|
||||
|
||||
Status: implementation candidate, not final-release acceptance.
|
||||
|
||||
- Linux x64 Release build: all targets compiled.
|
||||
- CTest: 32 passed, 157 skipped, zero failures (189 registered tests). Skips require separately configured original-data or save fixtures; they are not acceptance passes.
|
||||
- Synthetic tests cover unchanged executable image loading, nine original strength ranges, atomic rejection of malformed ranges, unsupported environment guards, and legacy/extended/truncated crest gates.
|
||||
- Public source scan: zero findings; generated differences catalogue matches source markers.
|
||||
- Version output: both GUI and console identify 1.0.0-rc.1.
|
||||
- Private crest probe: all 48 foreign league clubs in Diamond 3.7 resolve to original 38 × 38 W cells within atlas bounds. A native-size contact sheet was inspected; older Diamond data retain the neutral-crest gate.
|
||||
- Author defect reference: original hash and all 1,084 listed original/changed bytes checked. All 33 defects are tracked privately; source inspection is not regression acceptance.
|
||||
|
||||
Still required: dedicated original-game/GUI/save roundtrips, completing the original-defect audit, per-edition gameplay review, Windows/macOS native checks and release-package acceptance. No final 1.0 tag is justified by these checks alone.
|
||||
Reference in new issue
Block a user