Prepare Classic 1.0 edition rules and Diamond 3.7 foreign crests (by Codex)

This commit is contained in:
Codex committed 2026-10-30 15:39:56 +01:00
1 parent c293a35f56
commit 8ee062ea46
46 files changed
+296 -147

No files matched your search

+1 -1
View File
@@ -19,7 +19,7 @@ OpenBMH reconstructs the Bundesliga Manager Hattrick engine in C++20. The graphi
- Setup ignores mouse releases without a matching press on that screen, so
window activation cannot toggle the initial league/national-team selection
through that input path ([#10](https://github.com/Weyoune/openbmh/issues/10)).
- Source builds include the standalone [OBW installation converter](../../formats/obw/import.md).
- Source builds include the standalone [OBW installation converter](https://github.com/Weyoune/openbmh/blob/v0.2.1/docs/formats/obw/import.md).
It produces intermediate database conversions; game integration remains
planned for 0.2.
+46
View File
@@ -0,0 +1,46 @@
# Classic 1.0 backport audit
Baseline: v0.1.2. The release branch keeps the existing public history; the baseline restoration is an ordinary commit, not a force reset of main.
| Later change | Decision |
|---|---|
| 8326a23: host filenames/path display, setup input guards | Included; direct-installation code, no launcher/converter dependency |
| e1d17d8: explicit quit confirmation | Included; cancellation preserves current owner/state |
| c8f04d0: reschedule undo replay bit | Included; restores original target-day availability |
| b879d5b: standalone original message texts | Included as a focused adaptation; no native-content dependency |
| 978a014: edition-specific restored match-group expansion | Pending compatibility verification; no OBW save changes will be taken |
| 0b2354c: native file flows and English media | OBW paths excluded; applicable legacy filename correction reviewed separately |
| 856d38c / 500354c: RmlUI/WARP startup | Not applicable to the restored SDL Classic application; do not bring back RmlUI |
| 0.3 Modern manager placement correction | Excluded; belongs to Dreierpack Manager, not faithful Classic behaviour |
Version 1.0 no longer rewrites loaded rule tables to a shared profile. Original strength ranges and environment price steps are installed from the supplied edition. Environment implementations outside verified program fingerprints remain unverified, never silently enabled by a directory name.
This is an implementation audit, not a completed release acceptance report. Original-data, GUI, save compatibility and platform results must be recorded before the final tag.
## Diamond 3.7 foreign crests
The drawing policy is installed from the verified gate in the supplied executable.
Diamond 3.7 uses individual original W-sheet cells for the 48 foreign league clubs.
Earlier verified editions retain their neutral foreign-club crest. Database and
savegame selectors remain authoritative, including after club movement; no
high-resolution replacement pack or changed competition structure is required.
Unknown drawing gates retain the conservative legacy policy. National teams,
non-rostered clubs and missing-club tokens retain their existing treatment.
Private data verification decoded all 48 Diamond 3.7 selections and checked their
38-pixel cells against atlas bounds. This is an asset-path/contact-sheet check,
not a claim of completed interactive GUI acceptance.
## Author-supplied defect reference
The Diamond author supplied a private reference catalogue covering 33 original
bug corrections. The supplied original executable hash and all 1,084 documented
byte changes were independently checked against local original/Diamond files.
The archive and disassembly remain outside this public repository. Binary patch
caves are evidence of the old defect, not an implementation requirement.
Initial source review finds corrected camp field packing and separated card
save-back contexts already present. Their dedicated regression acceptance is
still pending. Retirement handling still excludes transfer-market slots and
requires correction. The complete 33-item review is tracked privately; none of
the unreviewed entries is claimed complete.
+9
View File
@@ -0,0 +1,9 @@
# OpenBMH 1.0 release candidate
Classic direct-installation runtime restored from v0.1.2. No launcher, converter, OBW runtime or Modern UI. The game executable is OpenBMH / OpenBMH.exe; openbmh_cli remains available.
Reviewed backports include host filename/path handling, explicit quit confirmation, original message text installation in standalone tools, and clearing the calendar replay flag after undoing a reschedule. German CD-compatible BMH and verified Diamond editions are the release targets. Football Limited remains experimental; the old floppy executable is unsupported.
This candidate is under compatibility validation, especially edition-dependent rules and environment behaviour. No complete platform or original-game acceptance is claimed before its recorded tests pass. Existing 0.2/editor releases remain historical; NextGen development moves to Dreierpack Manager.
Diamond 3.7 foreign league crests use the supplied edition's original drawing gate, database selectors and W sheets. Older editions retain their original neutral foreign-club crest.
+13
View File
@@ -0,0 +1,13 @@
# Classic 1.0 candidate validation
Status: implementation candidate, not final-release acceptance.
- Linux x64 Release build: all targets compiled.
- CTest: 32 passed, 157 skipped, zero failures (189 registered tests). Skips require separately configured original-data or save fixtures; they are not acceptance passes.
- Synthetic tests cover unchanged executable image loading, nine original strength ranges, atomic rejection of malformed ranges, unsupported environment guards, and legacy/extended/truncated crest gates.
- Public source scan: zero findings; generated differences catalogue matches source markers.
- Version output: both GUI and console identify 1.0.0-rc.1.
- Private crest probe: all 48 foreign league clubs in Diamond 3.7 resolve to original 38 × 38 W cells within atlas bounds. A native-size contact sheet was inspected; older Diamond data retain the neutral-crest gate.
- Author defect reference: original hash and all 1,084 listed original/changed bytes checked. All 33 defects are tracked privately; source inspection is not regression acceptance.
Still required: dedicated original-game/GUI/save roundtrips, completing the original-defect audit, per-edition gameplay review, Windows/macOS native checks and release-package acceptance. No final 1.0 tag is justified by these checks alone.