From a279bfb6df85d0fa1911af52d299e8c0f0158ba6 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 5 Nov 2026 21:04:00 +0100 Subject: [PATCH] Ignore the computer tip button once a visible result is known Co-Authored-By: Claude Sonnet 5.5 --- docs/DIFFERENCES.md | 1 + src/ui/league_pairings.cpp | 3 +++ 2 files changed, 4 insertions(+) diff --git a/docs/DIFFERENCES.md b/docs/DIFFERENCES.md index dd05bf2..0c44e1c 100644 --- a/docs/DIFFERENCES.md +++ b/docs/DIFFERENCES.md @@ -35,6 +35,7 @@ describe deliberate changes; they are not a list of every known compatibility li - [src/game/weekly.hpp](../src/game/weekly.hpp): uses the supported weekly processing and transfer rule profile. - [src/ui/bank.cpp](../src/ui/bank.cpp): read-only totals use wide arithmetic; individual saved account, price, holding and paid fields are unchanged. - [src/ui/desk_state.cpp](../src/ui/desk_state.cpp): the desk shows the opponent's badge whenever the data has one. +- [src/ui/league_pairings.cpp](../src/ui/league_pairings.cpp): the computer tip is ignored silently once a visible result is known, instead of raising an engine error. - [src/ui/league_table.hpp](../src/ui/league_table.hpp): uses three points for a win in the supported rule profile. - [src/ui/pitch.cpp](../src/ui/pitch.cpp): supports owner-bound designated set-piece selection in the extended manager record. - [src/ui/save_load.cpp](../src/ui/save_load.cpp): focuses the host save filename on entry and selects an existing name for replacement. diff --git a/src/ui/league_pairings.cpp b/src/ui/league_pairings.cpp index 6736051..950457a 100644 --- a/src/ui/league_pairings.cpp +++ b/src/ui/league_pairings.cpp @@ -368,6 +368,9 @@ bool LeaguePairingsScreen::release(int x,int y) { return true; } if(button==5)return true; // Source ellipsis has no action. + // OpenBMH deviates from the original: the computer tip is ignored silently once a visible result is known, instead of raising an engine error. + if(button==4&&std::any_of(state_.source.rows.begin(),state_.source.rows.end(), + [](const auto& row){return row.raw_result!=0xcc;}))return true; post({button==0?LeaguePairingsAction::reset:button==1?LeaguePairingsAction::search: button==2?LeaguePairingsAction::filter_by_club:button==3?LeaguePairingsAction::postponed_list: button==4?LeaguePairingsAction::computer_tip:LeaguePairingsAction::unsupported,button});return true;