Match all editor themes to modern submenu palettes (by Codex)

This commit is contained in:
Codex committed 2026-10-22 22:53:44 +02:00
1 parent fcf6092063
commit a475c1ba80
17 files changed
+274 -121

No files matched your search

+31 -4
View File
@@ -12,7 +12,26 @@ reviewed image hashes are allowlisted by the public-tree check.
| [Squads](roster-matchday-de.png) | Matchday theme, full squads and optional 24-row view |
| [Search](gui-search.png) | Actual keyboard input, focus retained across filtering |
| [Options](options-midnight-de.png) | Language, theme, integrated MCP toggle/port |
| [Image editor](image-editor-midnight-de.png) | Source-preserving crop, free rotation and mirroring; a simple synthetic vector portrait |
| [Image editor](image-editor-midnight-de.png) | Source-preserving crop, free rotation and mirroring; the demo's geometric SVG crest |
## Theme comparison
The three editor palettes follow the modern game's submenu colours. Midnight
uses a slate-grey gradient and restrained mint accents, Silver pale silver-blue
surfaces and petrol accents, and Matchday graphite surfaces and coral accents.
All components consume the inherited palette, including dropdown popups,
validation/error text, scrollbars, image stages and crop outlines. The comparison
uses the same German `World::demo()` view in each theme.
| Theme | Clubs | Options | Image editor |
|---|---|---|---|
| Midnight Glass | [View](clubs-midnight-de.png) | [View](options-midnight-de.png) | [View](image-editor-midnight-de.png) |
| Silver Glass | [View](clubs-silver-de.png) | [View](options-silver-de.png) | [View](image-editor-silver-de.png) |
| Matchday | [View](clubs-matchday-de.png) | [View](options-matchday-de.png) | [View](image-editor-matchday-de.png) |
[Previous Midnight view](https://github.com/Weyoune/openbmh/blob/fcf6092063c2354dec400462d5fa0c7dda3afe11/docs/qa/editor-poc/clubs-midnight-de.png)
provides the before image for the change from saturated navy to the submenu
palette. Data and layout are identical.
Environment: Debian 13 x86-64; actual SDL2/OpenGL/RmlUI window inside Xvfb,
software OpenGL requested with `LIBGL_ALWAYS_SOFTWARE=1`; 1440×900 window.
@@ -31,6 +50,13 @@ Validation performed:
JSON colour field retained; native search focus; shared MCP/native undo/redo;
save to OBW. This check caught and fixed RmlUI textarea entity handling and
select-initialization refresh loops.
- Native theme QA: switch Midnight → Silver → Matchday → Midnight through the
actual Options dropdown and Apply button; verify persisted settings and
compare rendered body, list and inspector pixels against a fresh startup
in each theme. Reopen the editor using the saved preference. Inspect the
Options popup, rejected invalid port input, dashboard, players, review,
history and image editor in each palette. The rejected input leaves the
saved options unchanged. No new platform GUI claim is implied.
- Private local checks, whose data is not published here: raw BMH and raw
Football Limited import, existing converted Classic OBWs, save/reopen, frozen
Classic portrait composition, and the large private merged 32-league world.
@@ -46,9 +72,10 @@ OpenBMHEditor --demo --page clubs --screenshot clubs.png --quit-after-ms 1800
```
The synthetic data is generated by `World::demo()`, not a career save. Options
files used for captures are local QA profiles and are not included. The vector
portrait uses a blue rectangle, a circular head and a rounded shoulder shape;
it is an image-editor fixture, not a real or AI-generated player.
files used for captures are local QA profiles and are not included. The image
editor captures use the demo's geometric SVG crest. Earlier history also
contains a synthetic portrait made from a blue rectangle, circular head and
rounded shoulders; no real or AI-generated player photo is used.
Windows x64/macOS ARM64 build and core/MCP checks are run by the separate
**OBW Editor POC** workflow. A CI pass is not a human GUI acceptance test on
Binary file not shown.

After

Width:  |  Height:  |  Size: 134 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 89 KiB

After

Width:  |  Height:  |  Size: 179 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 157 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 79 KiB

After

Width:  |  Height:  |  Size: 131 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 93 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

After

Width:  |  Height:  |  Size: 97 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 103 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 99 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 89 KiB

After

Width:  |  Height:  |  Size: 106 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 115 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 109 KiB

After

Width:  |  Height:  |  Size: 178 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 111 KiB

After

Width:  |  Height:  |  Size: 160 KiB