diff --git a/README.md b/README.md index 49f73b1..fa1d499 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # OpenBMH -**Classic-Version: 1.0.3 (Release-Vorbereitung).** Die originalgetreue Linie bleibt in diesem Repository. +**Classic-Version: 1.0.3.** Die originalgetreue Linie bleibt in diesem Repository. Erweiterte Ligen, die gemeinsame deutsche/englische Karriere und der Dateneditor werden separat als **[OpenBMH-Extended 1.0 Beta](https://github.com/Weyoune/OpenBMH-extended)** entwickelt. @@ -28,7 +28,7 @@ From a terminal in the extracted package on Linux or macOS: In Windows PowerShell, use `.\OpenBMH.exe` and `.\openbmh_cli.exe` instead. -Use a writable save directory and keep backups of existing games. German editions are the primary compatibility target. **Football Limited / English data support is experimental**; original V2.20 save import and some edition-specific behaviour remain limited. See the [release notes](docs/release/1.0/RELEASE_NOTES.md). +Use a writable save directory and keep backups of existing games. German editions are the primary compatibility target. **Football Limited / English data support is experimental**; original V2.20 save import and some edition-specific behaviour remain limited. See the [release notes](docs/release/1.0.3/RELEASE_NOTES.md). ## Features and direction diff --git a/docs/DIFFERENCES.md b/docs/DIFFERENCES.md index 5480f1d..37e37b1 100644 --- a/docs/DIFFERENCES.md +++ b/docs/DIFFERENCES.md @@ -24,6 +24,7 @@ describe deliberate changes; they are not a list of every known compatibility li - [src/game/season.cpp](../src/game/season.cpp): includes transfer-market players in retirement so the five-bit age cannot wrap to 16. - [src/game/season.cpp](../src/game/season.cpp): initializes the empty EM qualifier seeds with national teams, preventing club zero from entering the EM. - [src/game/season.hpp](../src/game/season.hpp): retains the enhanced academy player-generation strength bands with monthly youth budgets. +- [src/game/stadium_blocks.cpp](../src/game/stadium_blocks.cpp): allow 144,000 standard places and size-aware construction times while retaining edition-owned unit prices. - [src/game/state.hpp](../src/game/state.hpp): retains designated set-piece selections in the supported manager-record extension. - [src/game/week.cpp](../src/game/week.cpp): widen products before annual-rate division so valid native account amounts do not overflow intermediate sums. - [src/game/week.cpp](../src/game/week.cpp): an unknown history receives a grace month; later losses occur at most once per source month. diff --git a/docs/formats/FBM.md b/docs/formats/FBM.md index 69ba384..6e08bf2 100644 --- a/docs/formats/FBM.md +++ b/docs/formats/FBM.md @@ -26,6 +26,33 @@ The supported layout contains a fixed ordered block table, followed by four name Each name pool has a u16 byte length followed by that many bytes, in club, player, referee and stadium order. These pools preserve renamed entities. The splitter rejects missing/truncated blocks or pools and requires exact stream consumption. See [STATE](STATE.md) for interpreted records and [M3D](M3D.md) for pool references. +## Optional OpenBMH state + +After the four name pools, OpenBMH can append `OBMHEXT1`, a u16 block count, +then each block as a u32 identifier, u32 byte length and payload. There is at +most one such container and the decoder requires exact consumption of it. +Original saves have no container. The entire extension is included in the outer +rolling cipher and checksum. + +Known OpenBMH-owned sections include: + +| Identifier | Payload | Purpose | +|---|---|---| +| `OBLC` (`0x4f424c43`) | Versioned variable-length archive | [Long-career player counters and title winners](LONG_CAREER.md) | +| `BRM1` (`0x314d5242`) | Four little-endian u32 month-start keys (16 bytes) | Per-manager monthly high-cash robbery guard | + +A robbery key is the absolute first day of the last blocked source-calendar +month. `UINT32_MAX` means unknown. An unknown high-cash history receives a +first qualifying grace month; later deductions can occur at most once per +calendar month. Managers have independent keys. A truncated or duplicate BRM1 +section is rejected before game state is published. + +These identifiers describe OpenBMH-owned payloads, not original executable +addresses. The container can also hold explicitly supported compatibility blocks, +such as edition-specific cup state. Unrecognized payloads are not a general +persistence API. Original programs and older OpenBMH writers may reject or +discard optional information: keep a backup before opening a new save with them. + ## Edition compatibility Original Football Limited V2.20 saves use a different state block list despite sharing the signature and rolling cipher. They are not interchangeable with the V2.24 layout. Reading an English installation and importing its original saves are separate features; do not edit a version string to bypass the distinction. OpenBMH's own English careers use the session's supported save representation. diff --git a/docs/release/1.0.3/RELEASE_NOTES.md b/docs/release/1.0.3/RELEASE_NOTES.md index c011aa6..688a53b 100644 --- a/docs/release/1.0.3/RELEASE_NOTES.md +++ b/docs/release/1.0.3/RELEASE_NOTES.md @@ -1,38 +1,70 @@ -# OpenBMH Classic 1.0.3 +# OpenBMH 1.0.3 -Release candidate. Platform package and integrated QA results will be recorded -before publication. Extended development lives separately in +This Classic maintenance release fixes startup, dialog and match presentation, +transfer handling and several long-career limits. It uses the player's own +supported game installation. Extended development lives separately in [OpenBMH-Extended](https://github.com/Weyoune/OpenBMH-extended). -Changes under verification: +## Changes -- Football Limited date setup and prepared-image cache; case-insensitive paths - for Original CD data. -- A static Original title with its own palette, no loading balls, and a complete - left/right click to enter setup. -- Ordinary dialogs preserve the scene behind them. -- Scores remain at the previous result during goal scenes and update at reveal. -- A complete right-button release belongs to the dismissed table/overview. -- Original preferred-position swatches and colored pitch cursor are restored. -- Own transfer listings expose existing offers early. Viewing/canceling does not - alter the listing. Failed or refused listings can be listed again. -- Fresh arrivals do not inherit a previous occupant's contract-refusal flags. -- Saved wide player counters and title archives outlive native counter/window - boundaries; old lost history cannot be reconstructed. -- Interest/dividend intermediate arithmetic and Bank aggregate display use wide - values. Individual native account fields still have their documented limits. -- Bank robbery remains at the original threshold/amount but occurs at most once - per manager and calendar month, with a saved latch. An unknown older history - receives a grace month to avoid another deduction just after upgrading. -- Standard stadium blocks can reach144,000 places with edition-owned unit prices - and size-aware build periods. Existing saves retain their native capacity bytes. +- Football Limited startup reads its own calendar epoch and prepared-image + tables. Original CD assets are located without assuming filename case. +- The original title remains visible until a complete left or right mouse click, + without loading balls or automatic advancement. +- Career dialogs retain their scene background instead of inheriting the + executable's black boot-dialog mode. +- Goal scenes retain the previous visible score until the result is revealed. +- Closing a table or pairings overview owns the complete right-button gesture. +- Pitch placement again uses the edition's preferred-position colors and + original colored cursor. +- Select an owned transfer listing and use the sale action or Enter to inspect + existing offers before expiry. Cancel preserves the listing. Cleared listings + can be offered again; refusals receive visible feedback. +- A fresh squad arrival clears negotiation flags left by the previous occupant + of its row. This prevents inherited refusal of contract renewal. +- Optional saved archives preserve cumulative player counters and observed + title winners beyond the original byte/word and fifty-season windows. +- Daily interest and property/fund dividend products use wider intermediate + arithmetic; Bank portfolio totals use wide display values. +- The high-cash bank robbery remains, at most once per manager and calendar + month. Saving and loading preserves the limit. An older save with unknown + history receives a first qualifying month of grace. +- Standard stadium blocks now allow 144,000 places in total. Unit prices come + from the loaded edition; build periods increase with expanded block size. -Known limits: +## Validation -Calendar and rescheduling opened in the verified Classic datasets; the reported -failure remains an open Human-QA item. Some supplied saves (including a supplied -Diamond3.7 autosave) are rejected as damaged/unsupported before gameplay and are -not claimed repaired by unrelated transfer fixes. Histories are preserved only -from information available when this version starts. Older programs can discard -OpenBMH's optional save extensions. True multi-billion single-account storage -and every corresponding financial writer remain a separate unresolved issue. +The release workflow requires successful builds, configured synthetic tests and +package checks for Windows x64, macOS ARM64 and Linux x64 at the tagged revision. +Reports and checksums accompany the downloads. Missing external-data tests are +reported as skipped, rather than counted as successful game tests. + +Additional private Linux checks use Original CD, Diamond and Football Limited +assets for startup and setup, scene-backed dialogs, calendar/rescheduling, +transfer decisions, preferred-position feedback and score reveal. A 144,000-place +stadium was rendered after encrypted native save/load. These checks do not +constitute manual gameplay validation on Windows or macOS, or a full +200–300-season simulation. + +## Known limits + +- Individual native cash, deposit and financial-history fields remain 32-bit and + can still overflow. Wider calculations and aggregate display do not solve + multi-billion single-account storage; that issue remains open. +- Calendar and rescheduling opened in the checked Classic datasets; the reported + failure remains open because it could not be reproduced. +- Some supplied saves, including a supplied Diamond 3.7 autosave, are rejected as + damaged/unsupported before gameplay. This release does not claim to repair + those files. Football Limited remains experimental, including original V2.20 + save import. +- Already lost counters and earlier title winners cannot be reconstructed. The + separate manager-achievements graph retains its original fifty-season window. + Original programs and older OpenBMH writers can discard optional archive and + monthly-robbery extensions; keep backups before exchanging saves. +- The row-initialization correction does not clear genuine retirement/refusal + flags in an existing career or establish a fixed 200–300-season threshold. +- Early acceptance of a human-buyer loan still needs its separate consent flow + and is unavailable from the early offer preview. + +The public downloads contain implementation, corresponding source and notices; +original game content is not included. diff --git a/src/game/stadium_blocks.cpp b/src/game/stadium_blocks.cpp index 0960975..d287989 100644 --- a/src/game/stadium_blocks.cpp +++ b/src/game/stadium_blocks.cpp @@ -64,17 +64,30 @@ bool valid_resolved_offer(const StandBlockOffer& offer, const StadiumBlockExpans } } // namespace -StadiumBlockExpansionConstants stadium_block_expansion_constants(const LeImage& image){ - static constexpr std::array minima{14000,24000,14000,20000,14000,24000,14000,20000}; - StadiumBlockExpansionConstants out;uint32_t total=0; - for(size_t i=0;i<8;++i){out.price_per_1000[i]=image.u32(layout::CareerSession_DispatchStadium_RuntimeField+uint32_t((i+8)*4)); - const auto original=uint32_t(image.u8(layout::CareerSession_Invalid_RuntimeField+uint32_t(i)))*1000; - out.max_places[i]=std::max(original,minima[i]);total+=out.max_places[i]; - const auto source_weeks=image.u8(layout::CareerSession_DispatchStadium_RuntimeField2+uint32_t((i+22)*5)); - const auto weeks=std::max(source_weeks,2*(out.max_places[i]/1000)); - if(weeks>255)throw FormatError("stadium: expanded construction period exceeds saved byte");out.weeks[i]=uint8_t(weeks); +StadiumBlockExpansionConstants stadium_block_expansion_constants(const LeImage& image) { + // OpenBMH deviates from the original: allow 144,000 standard places and + // size-aware construction times while retaining edition-owned unit prices. + static constexpr std::array minima{ + 14000, 24000, 14000, 20000, 14000, 24000, 14000, 20000}; + StadiumBlockExpansionConstants out; + uint32_t total = 0; + for (size_t i = 0; i < minima.size(); ++i) { + out.price_per_1000[i] = image.u32( + layout::CareerSession_DispatchStadium_RuntimeField + uint32_t((i + 8) * 4)); + const auto original = uint32_t(image.u8( + layout::CareerSession_Invalid_RuntimeField + uint32_t(i))) * 1000; + out.max_places[i] = std::max(original, minima[i]); + total += out.max_places[i]; + const auto source_weeks = image.u8( + layout::CareerSession_DispatchStadium_RuntimeField2 + uint32_t((i + 22) * 5)); + const auto weeks = std::max(source_weeks, 2 * (out.max_places[i] / 1000)); + if (weeks > 255) + throw FormatError("stadium: expanded construction period exceeds saved byte"); + out.weeks[i] = uint8_t(weeks); } - if(total>255000)throw FormatError("stadium: combined stand limits exceed saved capacity byte");return out; + if (total > 255000) + throw FormatError("stadium: combined stand limits exceed saved capacity byte"); + return out; } std::optional quote_stadium_block_expansion(