From b879d5be008739f69afef562fb4bce56f1bdc778 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 24 Oct 2026 12:04:50 +0200 Subject: [PATCH] Install the engine's message texts in standalone tools (fixes #14) The six texts the engine posts from the game image (contract warning, Masters, indoor entry bonus, league title bonus, friendly share) were set only by the career sessions. week_check and the other standalone tools left them empty, so the indoor entry bonus mail held only the venue and the replays failed from the first public commit on. install_message_texts(exe) now sets them for both sessions and in the test executable loader. Classic regression: the ten turns of #14 (game 1: 18, 21, 65, 88, 109, 201, 247; 2P: 24, 29, 34) pass again; no other turn changed against the 0.3 M0 baseline. The divergence the issue saw in the youth teams block (bd4bc, since 310e3e2) is among the tolerated block differences. Co-Authored-By: Claude Opus 5.5 --- src/app/career_session.cpp | 7 +------ src/game/messages.cpp | 10 ++++++++++ src/game/messages.hpp | 6 ++++++ tests/runtime_fixture_tables.hpp | 5 ++++- 4 files changed, 21 insertions(+), 7 deletions(-) diff --git a/src/app/career_session.cpp b/src/app/career_session.cpp index 16282ba..20c047e 100644 --- a/src/app/career_session.cpp +++ b/src/app/career_session.cpp @@ -539,12 +539,7 @@ static void install_league_sizes(const LeImage& exe) { kNewcomerFirst = exe.u16(::bmh::layout::CareerSession_DispatchLineup_RuntimeField); kNewcomerCount = exe.u16(::bmh::layout::CareerSession_InstallLeagueSizes_RuntimeField6); // EXE strings the engine posts (messages.hpp) - kContractEndsSoonText = exe.cstring(kEnglishCompetitions ? ::bmh::layout::EnglishContractExpiryWarningText : ::bmh::layout::ContractExpiryWarningText); - kMastersQualificationText = kEnglishCompetitions ? "Masters entry confirmed. Your participation bonus has been credited." : exe.cstring(::bmh::layout::MastersQualificationText); - kMastersWinnerText = kEnglishCompetitions ? "Masters title won. Your prize money has been credited." : exe.cstring(::bmh::layout::MastersWinnerText); - kIndoorInvitationText = kEnglishCompetitions ? "Indoor event entry bonus credited for " : exe.cstring(::bmh::layout::IndoorInvitationText); - kChampionshipBonusText = kEnglishCompetitions ? "League title bonus credited." : exe.cstring(::bmh::layout::ChampionshipBonusText); - kFriendlyPayerPrefixText = kEnglishCompetitions ? "Your share: " : exe.cstring(::bmh::layout::NationalFriendlyPayerPrefixText); + install_message_texts(exe); } CareerSession::CareerSession(const std::filesystem::path& data, uint32_t watcom_seed) diff --git a/src/game/messages.cpp b/src/game/messages.cpp index ea4813f..66b4315 100644 --- a/src/game/messages.cpp +++ b/src/game/messages.cpp @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include "formats/executable_layout.hpp" #include "game/messages.hpp" +#include "game/schedule.hpp" #include #include @@ -150,4 +151,13 @@ std::string format_number(const GameState& g, int32_t value, int flags) { std::string format_amount(const GameState& g, int32_t value) { return format_number(g, value, 0x101); } +void install_message_texts(const LeImage& exe) { + kContractEndsSoonText = exe.cstring(kEnglishCompetitions ? ::bmh::layout::EnglishContractExpiryWarningText : ::bmh::layout::ContractExpiryWarningText); + kMastersQualificationText = kEnglishCompetitions ? "Masters entry confirmed. Your participation bonus has been credited." : exe.cstring(::bmh::layout::MastersQualificationText); + kMastersWinnerText = kEnglishCompetitions ? "Masters title won. Your prize money has been credited." : exe.cstring(::bmh::layout::MastersWinnerText); + kIndoorInvitationText = kEnglishCompetitions ? "Indoor event entry bonus credited for " : exe.cstring(::bmh::layout::IndoorInvitationText); + kChampionshipBonusText = kEnglishCompetitions ? "League title bonus credited." : exe.cstring(::bmh::layout::ChampionshipBonusText); + kFriendlyPayerPrefixText = kEnglishCompetitions ? "Your share: " : exe.cstring(::bmh::layout::NationalFriendlyPayerPrefixText); +} + } // namespace bmh diff --git a/src/game/messages.hpp b/src/game/messages.hpp index 9606a82..ca0f607 100644 --- a/src/game/messages.hpp +++ b/src/game/messages.hpp @@ -16,6 +16,7 @@ #include #include +#include "formats/le.hpp" #include "game/state.hpp" namespace bmh { @@ -59,6 +60,11 @@ inline std::string kIndoorInvitationText; inline std::string kChampionshipBonusText; inline std::string kFriendlyPayerPrefixText; +// Installs the six texts above from the game image (the English game uses its own wording). +// Both career sessions call it at start; standalone engine tools (week_check, the season sims) +// must call it too, or these messages lose their text (#14: the indoor entry bonus mail). +void install_message_texts(const LeImage& exe); + // FormatNumber(buf, value, 0x101, ""): an amount of money as the messages show it: the // value converted with CurrencyMultiplier / CurrencyDivisor, digits grouped by dots, then " EU". std::string format_amount(const GameState& g, int32_t value); diff --git a/tests/runtime_fixture_tables.hpp b/tests/runtime_fixture_tables.hpp index 110b066..eafe3d0 100644 --- a/tests/runtime_fixture_tables.hpp +++ b/tests/runtime_fixture_tables.hpp @@ -1,14 +1,17 @@ // SPDX-License-Identifier: GPL-3.0-only #pragma once #include "formats/le.hpp" +#include "game/messages.hpp" #include "game/schedule.hpp" namespace bmh::test { // Standalone engine tests explicitly install the supplied edition's scheduling -// content. CareerSession performs the same installation for normal app callers. +// content and the message texts. CareerSession performs the same installation for +// normal app callers. inline LeImage load_executable(const std::filesystem::path& path) { auto executable = bmh::load_le(path); install_fixture_tables(executable); + install_message_texts(executable); return executable; } }