Merge main into 0.3 before the Modern engine work

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ClaudeandClaude Opus 5.5 committed 2026-10-23 16:00:17 +02:00
commit cb0ba33cd2
86 files changed
+4324 -302

No files matched your search

+102 -9
View File
@@ -1,10 +1,23 @@
# OpenBMH Editor 0.5.0
# OpenBMH Editor 0.5.5
Der eigenständige, native Editor verwendet **RmlUI, SDL2 und OpenGL**. Er bearbeitet Startdatenbanken, keine laufenden Spielstände. Das Spiel und seine Classic-Prüfung bleiben unverändert. Editor 0.5.0 hat eine eigene Versionsreihe und den Release-Tag `editor-v0.5.0`; die Spielversion ist 0.2.0.
Der eigenständige, native Editor verwendet **RmlUI und SDL2**, unter Windows mit Direct3D 11, unter Linux/macOS mit OpenGL. Er bearbeitet Startdatenbanken, keine laufenden Spielstände. Das Spiel und seine Classic-Prüfung bleiben unverändert. Editor 0.5.5 hat eine eigene Versionsreihe und den Release-Tag `editor-v0.5.5`; die Spielversion ist 0.2.1.
## Windows-Start und Diagnose
Windows verwendet Direct3D 11 und wechselt bei fehlender Hardware automatisch auf
den integrierten WARP-Renderer. Der Editor und der Spiel-Launcher benötigen dort
keinen OpenGL-Treiber. Dieser Start wird auch mit erzwungenem WARP auf Windows
Server 2022 geprüft. Zum gezielten Testen lässt sich `OPENBMH_RML_DRIVER=warp`
setzen; die normale Auswahl erfolgt automatisch.
Startfehler erscheinen in einem nativen Dialog und werden zusätzlich unter
`%LOCALAPPDATA%\OpenBMH\OpenBMHEditor-startup.log` protokolliert. Bei einem
Aufruf aus PowerShell/CMD kann auch stderr umgeleitet werden. Headless- und
MCP-Aufrufe zeigen keinen modalen Fehlerdialog und behalten ihre Prozesscodes.
## Starten und Daten öffnen
Das vollständige Paket `OpenBMHEditor-0.5.0-<plattform>.zip` entpacken und `OpenBMHEditor.exe` (Windows) beziehungsweise `OpenBMHEditor` (Linux/macOS) starten. `assets/editor` muss beim Programm bleiben. Auf macOS kann die unsignierte Anwendung über **Rechtsklick → Öffnen** gestartet werden. Eine Signatur/Notarisierung ist nicht Bestandteil dieser Version. `OpenBMHEditor --version` zeigt die Editorversion ohne Grafikstart.
Das vollständige Paket `OpenBMHEditor-0.5.5-<plattform>.zip` entpacken und `OpenBMHEditor.exe` (Windows) beziehungsweise `OpenBMHEditor` (Linux/macOS) starten. `assets/editor` muss beim Programm bleiben. Auf macOS kann die unsignierte Anwendung über **Rechtsklick → Öffnen** gestartet werden. Eine Signatur/Notarisierung ist nicht Bestandteil dieser Version. `OpenBMHEditor --version` zeigt die Editorversion ohne Grafikstart.
**Öffnen** bietet OBW-Dateien und entpackte Welten an. **BMH / FLTD importieren** liest einen Ordner mit einer unterstützten BMH- oder Football-Limited-Installation durch den bestehenden Konverter. Das Original wird nicht überschrieben. Eine bestehende Classic-OBW wird zunächst überprüft und dann in eine bearbeitbare Editorwelt übernommen.
@@ -13,6 +26,7 @@ Das vollständige Paket `OpenBMHEditor-0.5.0-<plattform>.zip` entpacken und `Ope
## Bearbeiten
- Links einen Datenbereich auswählen; die Liste lässt sich durchsuchen, filtern, sortieren und seitenweise durchgehen. Rechts Änderungen mit **Anwenden** übernehmen. **Speichern** übernimmt auch die aktuellen Eingaben.
- **Doppelklick** auf ein Land zeigt seine Ligen, auf eine Liga ihre Vereine und auf einen Verein dessen Spieler. Land, Liga und Verein werden als Filter übernommen. Ein einfacher Klick wählt weiterhin den Datensatz zum Bearbeiten aus. Nicht übernommene Eingaben werden vor dem Wechsel abgefragt.
- Länder, Wettbewerbe, Vereine, Spieler, Kader, Stadien und Schiedsrichter lassen sich anlegen und bearbeiten. Referenzierte Datensätze werden erst nach Änderung ihrer Verknüpfungen gelöscht. Vereinswechsel zwischen Ligen aktualisieren auch deren Mitgliederlisten.
- Spielwerte behalten ihre **quellenspezifischen Wertebereiche**. Ein Classic-Wert wird nicht auf eine erfundene 1–10-Skala umgerechnet. Neue Spieler ohne belegte Werte bleiben zunächst unbewertet.
- Kader bleiben vollständig erhalten. Die Schaltfläche **24** schaltet lediglich die Seitengröße um. Spieler lassen sich über das Vereinsfeld verschieben, zum Tausch merken und mit einem anderen Spieler tauschen; die Pfeile ändern ihre Reihenfolge.
@@ -20,11 +34,67 @@ Das vollständige Paket `OpenBMHEditor-0.5.0-<plattform>.zip` entpacken und `Ope
- Rückgängig/Wiederholen gilt gemeinsam für native Oberfläche und MCP. Noch nicht angewendete Eingaben werden bei externen Änderungen nicht automatisch ersetzt; eine veraltete Änderung muss nach Aktualisierung erneut geprüft werden.
- **Bilder** und die Bildaktionen am Datensatz unterstützen PNG, JPEG, WebP und eigenständige SVG. Vor dem Import: Ausschnitt ziehen oder Werte eingeben, frei drehen, spiegeln. Ein unveränderter Import behält seine Originalbytes. Bearbeitete Rasterbilder werden PNG, SVG bleibt Vektor. Das Original und die Transformationswerte bleiben für erneutes Bearbeiten im Paket. Classic-Porträts werden aus ihren eingefrorenen Rezepten angezeigt; eine Umbenennung ändert das Gesicht nicht.
- Bildänderungen am Spieler, Verein oder Wettbewerb erhalten eine eigene Zuordnung. Gemeinsame Platzhalter und Bilder anderer Datensätze bleiben dabei erhalten. Im Bereich **Bilder** kann ein gemeinsam verwendetes Bild bewusst zentral bearbeitet werden.
- Ein Klick auf ein Wappen, Porträt, einen Pokal oder ein Bild in der Liste öffnet eine große, schreibgeschützte **Bildvorschau**. **Zum Asset** öffnet den zugehörigen Eintrag im Bereich **Bilder**. Bei zusammengesetzten Classic-Porträts ohne einzelne Bilddatei führt die Schaltfläche zur allgemeinen Bildübersicht. Das Anschauen verändert keine Daten; beim Wechsel bleiben offene Eingaben durch die Übernehmen-/Verwerfen-Abfrage geschützt.
**Speichern** erzeugt ausschließlich `.obw` im Profil **`editor-world-v1`, Format 1.1**. Editorwelten sind **noch nicht im Classic-Spiel startbar**. Die Bezeichnung ist im Editor sichtbar. Unbekannte Erweiterungen, nicht bearbeitete Dokumente, Quellnachweise und Bilder bleiben erhalten. Noch nicht im Formular angebotene Regeln, Kalender- und Finanzdaten werden erhalten, aber nicht als vollständig editierbare Bereiche ausgegeben.
Shortcuts: Ctrl/Cmd+O, Ctrl/Cmd+S, Shift+Ctrl/Cmd+S, Ctrl/Cmd+Z und Shift+Ctrl/Cmd+Z. In Textfeldern gilt die lokale Text-Rückgängig-Funktion.
## Zurück und Vorwärts
Ein **Rechtsklick** an beliebiger Stelle öffnet **Zurück / Vorwärts**. Dieselbe
Navigation funktioniert mit **Alt+Links / Alt+Rechts** und den beiden seitlichen
Maustasten. Nicht verfügbare Richtungen sind ausgegraut. Escape oder ein Klick
außerhalb schließt das Menü.
Der Verlauf merkt Datenbereiche, Doppelklick-Absprünge, Vergleichsansichten und
Asset-Verknüpfungen. Beim Zurückkehren werden Filter, Suche, Sortierung,
Datensatzauswahl, Tabellenseite und Scrollpositionen wiederhergestellt.
Filtereingaben und einfache Zeilenauswahl erzeugen keine einzelnen Verlaufsschritte.
Offene Formulareingaben werden weiterhin vor dem Wechsel abgefragt; Abbrechen
lässt die Position im Verlauf unverändert. Ein neuer Absprung nach Zurück ersetzt
den bisherigen Vorwärtszweig. Das Öffnen einer anderen Welt, auch über MCP,
setzt den Verlauf zurück. **Zurück** ist unabhängig von **Rückgängig** und ändert
keine Daten.
Die Dropdowns verwenden die Gestaltung der Modern-Desktop-Untermenüs:
leichte Verläufe, runde Popup-Listen, ein Häkchen am gewählten Wert und dieselbe
Schriftgröße in geschlossenem Feld und Auswahlliste. Escape schließt zuerst die
offene Auswahlliste. [Native Vergleichsbilder](qa/editor-navigation/README.md)
zeigen die Darstellung in allen drei Themes.
## CPU im Leerlauf
Ab 0.5.4 zeichnet der Editor nur bei Eingaben, sichtbaren Änderungen oder von
RmlUI angeforderten Zeitereignissen. Ein unveränderter Bildschirm benötigt keine
fortlaufenden Frames. Textcursor, Animationen, Scrollen und externe MCP-Änderungen
bleiben aktiv; minimierte Fenster zeichnen nicht. Die vorherige Dauerschleife
konnte insbesondere mit dem WARP-Softwarerenderer unter Remote Desktop einen
erheblichen Teil der CPU belegen. Import, Bildverarbeitung und andere tatsächliche
Datenarbeit benötigen weiterhin Rechenzeit.
## Stärken und Gehälter vergleichen
**Wertevergleich** in der Seitenleiste (oder die gleichnamige Schaltfläche bei Spielern, Vereinen und Wettbewerben) öffnet eine Übersicht mit drei Ansichten: **Spieler**, **Mannschaften**, **Ligen**. Spieler zeigen ihre einzelnen Spielwerte und das Gehalt je Saison; Mannschaften und Ligen zeigen Durchschnittswerte, Spielergehaltssummen, das Durchschnittsgehalt und die Anzahl bekannter Gehälter. Ein Klick auf eine Zeile öffnet ihren Datensatz zur Bearbeitung.
- Auf einen Spaltenkopf klicken, um auf- oder absteigend zu sortieren. Sortiert wird der gesamte gefilterte Bestand vor der Aufteilung auf Seiten mit bis zu 200 Zeilen. Suche sowie Land-, Liga- und Vereinsfilter grenzen die Ansicht ein. Fehlende Zahlen stehen in beiden Sortierrichtungen hinten.
- **Spalten auswählen** blendet beliebige vorhandene Spielwerte ein. Bei vielen Spalten horizontal scrollen; Tabellenkopf und Werte bewegen sich gemeinsam. Die Wertebereiche stehen im Spaltenkopf, Gruppenwerte sind spielergewichtete Durchschnitte über bekannte Werte. Der gesamte Kader einschließlich Reserve zählt; reine Quellenduplikate mit `x-simulation.squad_role: source-only-duplicate` werden ausgeschlossen und ihre Anzahl angezeigt.
- Verschiedene Attributsysteme bleiben getrennt. Bei einem einzigen System werden dessen Spielwerte automatisch angezeigt. Bei mehreren ein **Attributsystem** wählen, um dessen Spieler und die daraus gebildeten Mannschafts-/Ligawerte zu vergleichen. Das FC-Attribut `strength` heißt in einem System mit `overall` **Körperkraft**; es wird nicht als Classic-Gesamtstärke interpretiert. Es wird keine neue Stärkeskala berechnet.
- **Gehälter gelten je Saison**, in der Währung und kleinsten Einheit aus dem OBW-Manifest. Berücksichtigt werden zum Saisonstart gültige Verträge des Spielers mit seiner aktuellen Mannschaft. Personalverträge, abgelaufene und zukünftige Verträge zählen nicht. Mehrere gleichzeitig gültige Verträge derselben Zuordnung sind unklar und werden nicht addiert. Ohne Vertragsangabe steht **—**, ein ausdrücklich gespeichertes Nullgehalt bleibt **0**.
- Unvollständige Gehaltssummen und Durchschnitte tragen ein **\***. Sie berücksichtigen nur bekannte Spielergehälter; die Spalte **Gehälter bekannt** zeigt die Abdeckung. Auch Spielwertdurchschnitte verwenden nur bekannte Werte (Anzahl per Tooltip). Classic-Grunddaten liefern häufig keine konkreten Verträge: Der Editor erfindet diese Gehälter nicht.
[Native Vorher-/Nachher-Bilder](qa/editor-comparison/README.md) dokumentieren die Ansichten und Spaltenauswahl.
Die Übersicht verändert weder Daten noch Undo-Historie. Änderungen und Rückgängig aktualisieren ihre Werte automatisch. Alle drei Themes und beide Sprachen werden unterstützt.
Über MCP liefert **`editor_compare`** dieselbe schreibgeschützte Übersicht. Beispielargumente:
```json
{"table":"players","sort":"attributes.overall","descending":true,"limit":200}
```
`table` ist `players`, `clubs` oder `leagues`. Weitere Sortierschlüssel sind `name`, `salary` (Spieler), `salary_total`, `salary_average`, `salary_known`, `player_count`, `club_count` sowie `attributes.<feld>`. `attribute_set` grenzt das System ein, `search`, `nation`, `competition`, `team` filtern, `offset`/`limit` blättern. Die Antwort enthält Originalskalen, Stichtag, Währung und Abdeckung. Gehälter bleiben Integer in kleinster Währungseinheit; das Durchschnittsgehalt wird auf diese Einheit gerundet. Das entsprechende Session-Kommando für Command-Scripts heißt `compare`.
## Optionen und MCP
**Optionen** bietet Deutsch/Englisch, Midnight Glass/Silver Glass/Matchday und den integrierten MCP-Server. Die Sprache ändert die Oberfläche; Namen und Quelldaten werden nicht übersetzt. Einstellungen werden im Benutzerprofil gespeichert.
@@ -39,18 +109,35 @@ Unter **Darstellung** stehen die drei Farbwelten der modernen Untermenüs zur Au
Der MCP-Server ist standardmäßig aktiviert und bindet ausschließlich `127.0.0.1`, standardmäßig Port `8765`. Port `0` wählt einen freien Port. Status und tatsächlicher Port sind in Optionen sichtbar. **Verbindung kopieren** kopiert eine JSON-Konfiguration einschließlich Bearer-Token für HTTP-fähige MCP-Clients. Das Token bleibt lokal im Benutzerprofil und wird nur auf ausdrückliches Kopieren/CLI-Anfordern ausgegeben. Ein anderer bereits laufender Editor kann den Standardport belegen; dann einen anderen Port wählen.
Implementiert ist [MCP Streamable HTTP 2025-11-25](https://modelcontextprotocol.io/specification/2025-11-25/basic/transports), mit Aushandlung von 2025-06-18; JSON-Antworten, ohne optionale SSE-Sitzungen. Neuere MCP-Versionen werden nicht als unterstützt beworben. Der Server prüft Token, Host und gegebenenfalls Origin. Oberfläche und Agent bearbeiten dieselbe Welt, verwenden dieselbe Validierung und dieselbe Undo-Historie. Für konkurrierende Änderungen `expected_revision` aus `editor_info`/`editor_get` mitsenden.
Implementiert ist [MCP Streamable HTTP 2025-11-25](https://modelcontextprotocol.io/specification/2025-11-25/basic/transports), mit Aushandlung von 2025-06-18; JSON-Antworten, ohne optionale SSE-Sitzungen. Neuere MCP-Versionen werden nicht als unterstützt beworben. Der Server prüft Token, Host und gegebenenfalls Origin. Oberfläche und Agent bearbeiten dieselbe Welt, verwenden dieselbe Validierung und dieselbe Undo-Historie. Für konkurrierende Änderungen `expected_revision` aus `editor_info`/`editor_get` mitsenden. `editor_info.world_generation` kennzeichnet die aktuell geladene Welt innerhalb der Sitzung: Öffnen/Neu erhöht den Wert, Bearbeiten, Speichern und Rückgängig behalten ihn bei. Er wird nicht im OBW gespeichert.
Werkzeuge: `editor_info`, `editor_open`, `editor_new`, `editor_list`, `editor_get`, `editor_apply`, `editor_rules`, `editor_validate`, `editor_history`, `editor_save`, `editor_undo`, `editor_redo`, `editor_roster_move`, `editor_roster_swap`, `editor_roster_order`, `editor_review_resolve`, `editor_image_import`, `editor_image_edit`, `editor_image_preview`, `editor_image_export`. Die eingeblendeten Tools enthalten Parameterschemata und Beschreibungen. Öffnen einer anderen Welt verwirft ungespeicherte Änderungen nur mit `discard: true`.
Werkzeuge: `editor_info`, `editor_open`, `editor_new`, `editor_list`, `editor_compare`, `editor_regulations`, `editor_get`, `editor_apply`, `editor_rules`, `editor_validate`, `editor_history`, `editor_save`, `editor_undo`, `editor_redo`, `editor_roster_move`, `editor_roster_swap`, `editor_roster_order`, `editor_review_resolve`, `editor_image_import`, `editor_image_edit`, `editor_image_preview`, `editor_image_export`. Die eingeblendeten Tools enthalten Parameterschemata und Beschreibungen. Öffnen einer anderen Welt verwirft ungespeicherte Änderungen nur mit `discard: true`.
## Spiel- und Ligaregeln ansehen
**Regelwerk** zeigt Auf- und Abstieg, Ziel-Ligen, Relegation und internationale
Qualifikation. Wettbewerbe lassen sich durchsuchen und nach Land filtern.
**Spielregeln** zeigt die übernommenen Einträge aus `world/rules.json`, etwa
Wertebereiche, Kreditfaktoren, Trainingslager und Classic-Verfahren. Phasen und
weitere Originalfelder sind ebenfalls einsehbar. Dieser Bereich ist vollständig
schreibgeschützt; er verändert weder Welt noch Undo-Historie.
Explizite OBW-Regeln werden direkt dargestellt. Bei Classic-Importen kennzeichnet
die Ansicht die versionierten Classic-Verfahrensregeln. Parallel-Ligen behalten
Meister plus bedingte Relegationsplätze; die unterste Liga nutzt den Nachrückerpool.
Internationale Plätze folgen dem ursprünglichen Champions-League-/UEFA-/
Pokalsieger-Cup-Verfahren. Nicht festgelegte Regeln bleiben als solche sichtbar.
Das sind keine heutigen UEFA-Regeln und kein neuer Saison-Simulator.
`editor_regulations` bietet dieselben Informationen schreibgeschützt über MCP.
## Kompilieren
Voraussetzungen entsprechen dem Hauptprojekt: C++20-Compiler, Git, CMake ≥ 3.24 und Ninja. Windows: Visual Studio 2022 C++ Build Tools / x64 Native Tools Prompt; macOS ARM: Xcode Command Line Tools, CMake und Ninja; Linux: GTK3-, X11- und OpenGL-Entwicklungspakete wie im Haupt-README. Die Grafikausgabe benötigt OpenGL 3.3, auf macOS OpenGL 4.1.
Voraussetzungen entsprechen dem Hauptprojekt: C++20-Compiler, Git, CMake ≥ 3.24 und Ninja. Windows: Visual Studio 2022 C++ Build Tools / x64 Native Tools Prompt; macOS ARM: Xcode Command Line Tools, CMake und Ninja; Linux: GTK3-, X11- und OpenGL-Entwicklungspakete wie im Haupt-README. Windows nutzt Direct3D 11 mit automatischem WARP-Software-Fallback; Linux benötigt OpenGL 3.3, macOS OpenGL 4.1.
```sh
cmake -S . -B build-editor -G Ninja -DCMAKE_BUILD_TYPE=Release -DOPENBMH_BUILD_EDITOR=ON
cmake --build build-editor --target openbmh_editor editor_core_tests --parallel 2
ctest --test-dir build-editor -C Release -R '^editor_(core_tests|version)$' --output-on-failure
cmake --build build-editor --target openbmh_editor editor_core_tests editor_comparison_tests editor_regulations_tests --parallel 2
ctest --test-dir build-editor -C Release -R '^editor_(core_tests|comparison_tests|regulations_tests|version)$' --output-on-failure
```
macOS ARM zusätzlich bei der Konfiguration: `-DCMAKE_OSX_ARCHITECTURES=arm64 -DCMAKE_OSX_DEPLOYMENT_TARGET=11.0`. Unter Windows das Argument nach `-R` ohne einfache Shell-Anführungszeichen verwenden. Der Editor wird beim normalen Spiel-Build standardmäßig nicht mitgebaut.
@@ -71,8 +158,14 @@ Pakete baut `tools/package/make_editor_package.py --build build-editor --out dis
Extract the complete package and run **OpenBMHEditor**. Open an OBW archive or an unpacked world, import a supported BMH/Football Limited installation, or open the synthetic demo. Use the sidebar, searchable/filterable list and property inspector; **Apply** records one shared, undoable transaction. **Save** writes only an **OBW 1.1 editor world**, not a playable Classic mod or a legacy installation.
Use **Comparison** to inspect sortable player, team and league ratings and per-season salaries. Select attribute columns and filter by country, league, club or attribute system. Group ratings are player-weighted means; salary totals and means use known player contracts only and explicitly flag incomplete coverage. Missing values remain unknown. The read-only MCP tool `editor_compare` returns the same data.
Use **Regulations** to inspect promotion, relegation, playoffs, international qualification and stored game rules. Explicit OBW declarations and versioned Classic policies are distinguished; missing rules stay unspecified. This page and `editor_regulations` are read only.
The editor retains full squads, original image data, source claims and unknown extensions. Its 24-player view does not remove players. Image import offers normalized crop, arbitrary rotation and mirroring; re-editing uses the preserved source. Classic portraits keep their frozen appearance recipe. Unsupported editing areas are preserved rather than replaced.
Click a crest, portrait, trophy or list thumbnail to open a large read-only image preview. **View asset** opens its linked asset record; composed Classic portraits without a single image file lead to the image library. Viewing preserves the world and pending property edits.
In **Options**, switch the interface to **English**, choose one of the three themes, and enable/disable the integrated local MCP server. **Copy connection** provides the authenticated configuration. The server defaults to loopback port 8765; use port 0 for a free port. GUI and MCP share the same world, validation and undo history. It supports MCP Streamable HTTP 2025-11-25/2025-06-18 and optional stdio mode. Use `expected_revision` for concurrent edits.
Build with the three commands above, including `-DOPENBMH_BUILD_EDITOR=ON`. The native application requires OpenGL 3.3 (macOS 4.1) and the platform development dependencies documented in the main README. Editor 0.5.0 is unsigned and does not bundle any real-world dataset or proprietary game assets.
Build with the three commands above, including `-DOPENBMH_BUILD_EDITOR=ON`. Windows uses Direct3D 11 with automatic WARP software fallback. Linux requires OpenGL 3.3; macOS requires OpenGL 4.1, plus the documented platform development dependencies. Editor 0.5.5 is unsigned and does not bundle any real-world dataset or proprietary game assets.
+71 -44
View File
@@ -1,6 +1,6 @@
# Engine split: Classic, Classic Extended and Modern
Status: **concept and migration plan**. It prepares one shared match engine under three season engines. Nothing in this document changes the behaviour of the current release.
Status: **concept and migration plan**. It prepares one shared match engine under the season engines of three game variants. Nothing in this document changes the behaviour of the current release.
## 1. Goal
@@ -8,27 +8,35 @@ OpenBMH will offer three game variants:
| Variant | Data | Season engine | Interface | State |
|---|---|---|---|---|
| **Classic** | Imported from the user's BMH or FLTD installation (OBW `runtime:classic-v1`) | The current engine: fixed calendar, 9 leagues, original competition structure and rules | Classic 320×200 interface | Essentially complete |
| **Classic Extended** | Classic data plus extension data | Classic engine with optional, switchable extensions | Classic interface plus additional screens in the same style | Not started |
| **Modern** | Typed OBW worlds (imported or own) | New engine: generated calendar, data-driven leagues and competitions, playable foreign leagues | New high-resolution interface (RmlUi) | Interface in progress |
| **Classic** | Imported from the user's BMH or FLTD installation (OBW `runtime:classic-v1`) | Classic: fixed calendar, 9 leagues, original competition structure and rules | Classic 320×200 bitmap interface | Essentially complete |
| **Classic Extended** | Classic data, optionally extended where the classic screens can show it | Working idea: Classic engine plus features **backported from Modern**, step by step (§4) | Classic bitmap interface, extended by hand per feature | Open; after Modern |
| **Modern** | New OBW data set (imported and extended, or own worlds) | Modern: generated calendar, data-driven leagues and competitions, playable foreign leagues, leagues larger than 12 teams | New high-resolution interface (RmlUi), designed for many leagues | Interface in progress |
All three use **the same match engine**. A match between two given teams under the same rules is simulated by the same code in every variant; only what happens around it (calendar, competitions, finances, transfers, development) differs.
### 1.1 Where a change belongs
- **Classic** receives changes that work with the imported original assets and the original data layout: bug fixes, quality of life, small rule corrections, menus such as the environment menu of a later DIAMOND release.
- **Modern** is where new features are designed first, without the limits of the original screens or data layout: more leagues, foreign leagues with more than 12 teams, a free calendar, new competitions and systems.
- **Classic Extended** takes Modern features back into the Classic engine **one at a time**, where the bitmap interface can present them with reasonable manual work. The classic screens were never designed for variable structures, so Classic Extended will never offer every Modern feature; each backport is a decision of its own (§4).
## 2. Target architecture
```
Classic UI Classic Extended UI Modern UI (RmlUi)
\ | /
+-------- app / protocol layer -------+ variant capabilities
/ | \
season: classic season: classic + extensions season: modern
(GameState image) (GameState image + ext state) (typed OBW model)
\ | /
+------ match adapter (per engine) ---+
|
match engine (bmh_match: typed contract)
|
random sources, attribute set bmh-classic@1
Classic UI (bitmap) Classic UI + extra screens Modern UI (RmlUi)
| | |
+---------------- app / protocol layer (capabilities) -------+
| | |
season: classic season: classic + backported features season: modern
(GameState image) (GameState image + extension state) (typed OBW model)
| | \ / |
| | shared feature modules |
| | (bmh_features, ports) |
+------------------ match adapter (per engine) --------------+
|
match engine (bmh_match: typed contract)
|
random sources, attribute set bmh-classic@1
```
### 2.1 Libraries
@@ -37,11 +45,21 @@ All three use **the same match engine**. A match between two given teams under t
|---|---|---|
| `bmh_match` | Minute simulation, events, chances, cards, injuries during the match, substitutions, live interventions, the Reality scene and reporter | `random`, the match contract types; **not** `GameState`, calendar, finances |
| `bmh_season_classic` | Today's `src/game` without the match core: turn driver, weekly/monthly/season processing, cups, transfers, finances, post-match effects | `bmh_match`, `bmhcore` formats |
| `bmh_season_classic_ext` | Extension modules on top of Classic (§4) | `bmh_season_classic` |
| `bmh_season_modern` | New season engine on the typed OBW model (§5) | `bmh_match`, `bmh_world` |
| `bmh_world` | Typed OBW model, reader/writer, validator, importers (`src/import`) | `bmhcore` formats |
| `bmh_season_classic_ext` | Classic Extended: registry of backported features, their state and hook points in the Classic turn (§4) | `bmh_season_classic`, `bmh_features` |
| `bmh_features` | Season features written once for Modern and reusable by Classic Extended, each against small **ports** (interfaces) instead of a concrete state model | the match contract types only |
| `bmh_season_modern` | New season engine on the typed OBW model (§5) | `bmh_match`, `bmh_features`, `bmh_world` |
| `bmh_world` | Typed OBW model, reader/writer, validator (`src/content`, `src/import`) | `bmhcore` formats |
The dependency rule: **the match engine knows no season engine**, and no season engine reaches into another one's state.
The dependency rules: **the match engine knows no season engine**; no season engine reaches into the state of another; **no season engine knows an interface**; a feature in `bmh_features` knows neither `GameState` nor the OBW model, only its ports.
### 2.2 Writing Modern features so they can be backported
Backporting is cheap only if a feature is written for it from the start:
- The rules of a feature (for example youth development, a staff system, sponsor negotiation) live in `bmh_features` and read and write the game only through a port: `PlayerRoster`, `ClubFinance`, `Calendar`, `Mailbox`, `RandomSources` and similar narrow interfaces.
- Modern implements the ports on the typed model. Classic Extended implements the same ports as adapters on `GameState` plus its extension state.
- A feature declares what it needs (ports, data fields, calendar events) and which presentation it needs (screens, messages). This declaration is the checklist for a backport: if the Classic adapter cannot provide a port, or no classic screen can show the result, the feature stays Modern-only.
- Features that depend on Modern-only structures (generated calendar, generic competition stages, leagues of variable size) are marked as such and are not candidates.
## 3. The match contract
@@ -94,7 +112,7 @@ The match engine draws only through an injected `RandomSources` interface with t
### 3.5 Attribute set
The match engine consumes players in attribute set `bmh-classic@1` (OBW §5.3). Classic and Classic Extended already store exactly this. Modern may keep richer attributes for its own systems, but provides a `bmh-classic@1` projection for every player it sends into a match. A later, finer match model would be a **new version** of the match engine with its own attribute set, selectable per variant; it is not part of this plan.
The match engine consumes players in attribute set `bmh-classic@1` (OBW §5.3). Classic already stores exactly this. Modern may keep richer attributes for its own systems, but provides a `bmh-classic@1` projection for every player it sends into a match. A later, finer match model would be a **new version** of the match engine with its own attribute set, selectable per variant; it is not part of this plan.
### 3.6 Versioning
@@ -102,22 +120,29 @@ The match engine consumes players in attribute set `bmh-classic@1` (OBW §5.3).
## 4. Classic Extended
Classic Extended is **Classic plus switchable extensions**:
> **Working idea, not a decision.** Backporting Modern features into the Classic engine is the current idea for Classic Extended; the variant may take a different shape. What does not depend on it: the shared match engine (§3), the Modern engine driven only through the protocol, and features written against ports (§2.2), which keep several options open.
- It runs on the Classic season engine and the Classic save layout, plus one additional state block for extensions (`x-extended/` in OBW saves).
- Each extension is a module with an id, a version, its own state, its rules and its screens. A career records which extensions it uses.
- **Invariant:** with every extension switched off, Classic Extended produces exactly the Classic results. A test runs the Classic regression through the Extended engine with no extensions.
- Extensions hook into defined points of the Classic turn (start/end of day, week, month, season; before/after matchday; desk actions), never into the middle of a Classic routine.
- Its screens use the classic interface toolkit (`src/ui`), in the same resolution and style.
- Candidates for first extensions: the environment ("Umfeld") menu of a later DIAMOND release (reviewed against our rule base, documented as a deviation), more statistics and history screens, quality-of-life automation, configurable rule values (roadmap 0.3).
Classic Extended is the **Classic season engine plus backported Modern features**, presented in the classic bitmap interface.
- **Invariant:** with every backported feature switched off, Classic Extended produces exactly the Classic results. A test runs the Classic regression through the Extended engine with no features.
- Each backported feature is a module with an id and version, its own state (`x-extended/` in OBW saves), the Classic adapters for its ports and its classic-style screens. A career records which features it uses; features can be switched on at career start and, where safe, later.
- Features hook into defined points of the Classic turn (start/end of day, week, month and season; before/after a matchday; desk actions), never into the middle of a Classic routine.
- **Data:** Classic Extended starts from Classic data. A feature may bring additional data, but only in a shape the classic screens can show. Structures that change the size of what the screens list (more or larger leagues, new competitions) are Modern-only unless a specific screen is redesigned for them.
- **Interface cost per feature**, the main factor in each backport decision:
1. The result fits existing screens (a new value on the player card, a message, a desk action): small.
2. A new screen of fixed size in the classic style (a staff or youth screen): medium, new own artwork needed.
3. A screen whose content grows with the data (longer tables, more league selectors, calendar views): large, often not worth it.
- **Assets:** the original bitmaps of the user's installation plus new classic-style artwork. New artwork must be the project's own.
- Order of work: a feature is built and settled in Modern first, then backported if its ports and its presentation fit (§2.2).
## 5. Modern
Modern is a new season engine on the typed OBW model (`docs/formats/OBW.md`):
- **Data set:** an OBW world that goes beyond the original structure, for example foreign leagues with more than 12 teams, more leagues (up to 32) and real-world competition formats. It can start from an imported Classic world and be extended, or be a world of its own.
- **Calendar:** generated each season from `world/calendar.json` (series, windows, events) instead of a fixed day table; any season start, international windows, winter breaks per nation.
- **Competitions:** the generic stage model (league, groups, league phase, knockout, playoff, final) with declarative slots and promotion/relegation; up to 32 leagues; foreign leagues are playable, not only simulated.
- **Systems:** finances, transfers, contracts, youth, staff and development are rewritten on the typed model, reusing Classic formulas where they fit, documented where they differ.
- **Competitions:** the generic stage model (league, groups, league phase, knockout, playoff, final) with declarative slots and promotion/relegation; foreign leagues are playable, not only simulated.
- **Systems:** finances, transfers, contracts, youth, staff and development are rewritten on the typed model, reusing Classic formulas where they fit and documenting where they differ.
- **Interface:** the RmlUi client through the app/protocol layer only.
- Matches always go through the shared match contract (§3).
@@ -125,10 +150,10 @@ Modern does not have to reproduce Classic results; its quality gate is plausibil
## 6. Variant selection and saves
- The world or save manifest names the runtime: `requires: ["runtime:classic-v1"]`, `["runtime:classic-extended-v1"]` or `["runtime:modern-v1"]`, plus `match@1`.
- `CareerSession` selects the season engine from the manifest; the protocol reports **capabilities** per variant, so interfaces and console clients only offer supported actions.
- Conversions are **one-way**: Classic → Classic Extended (switch on extensions), Classic or Classic Extended → Modern (convert to the typed model). There is no way back, and the original file is kept.
- Legacy `.FBM` saves stay Classic.
- The world or save manifest names the runtime: `requires: ["runtime:classic-v1"]`, `["runtime:classic-extended-v1"]` (with the list of active features and their versions) or `["runtime:modern-v1"]`, plus `match@1`.
- `CareerSession` selects the season engine from the manifest; the protocol reports **capabilities** per engine and feature, so interfaces and console clients only offer supported actions.
- Conversions are **one-way**: Classic → Classic Extended (switch features on), Classic or Classic Extended → Modern (convert to the typed model; backported feature state maps to the Modern original of the feature). There is no way back, and the original file is kept.
- **All variants save only in the OBW format** (`.obs`). Legacy `.FBM` saves are an import source only: they are converted into a Classic `.obs` career and never written.
## 7. Migration plan
@@ -141,23 +166,25 @@ Each step keeps the game playable and the Classic regression (`tools/regression/
| 2 | Introduce `RandomSources`; the match core no longer touches the global streams directly | Regression identical |
| 3 | Typed `MatchdaySetup`/`MatchdayResult`; Classic adapter builds the setup from `MatchGroup`/`GameState` and writes results back; move post-match effects out of the minute loop into `bmh_season_classic` | Regression identical; match contract tests |
| 4 | Remove the remaining `GameState` dependencies from `bmh_match` (enforced by the build: `bmh_match` does not link `GameState`) | Build rule; regression identical |
| 5 | Variant field in manifests, engine selection in `CareerSession`, capability reporting in the protocol | Classic unchanged; capability tests |
| 6 | Classic Extended skeleton: extension registry, hook points, `x-extended` state, "all extensions off = Classic" test | Regression identical through Extended |
| 7 | Modern season engine on `bmh_world`, first with one nation and the shared match engine, then the competition model, then foreign leagues | Modern plausibility runs |
| 8 | First Classic Extended extensions; Modern feature growth | Per extension/feature |
| 5 | Runtime field in manifests, engine selection in `CareerSession`, capability reporting in the protocol | Classic unchanged; capability tests |
| 6 | `bmh_features` with the first ports; Modern season engine on `bmh_world`, first with one nation and the shared match engine, then the competition model, then foreign leagues and larger leagues | Modern plausibility runs |
| 7 | Classic Extended skeleton: feature registry, hook points, `x-extended` state, Classic adapters for the first ports, "no features = Classic" test | Regression identical through Extended |
| 8 | Backports one feature at a time, each with its interface cost assessed (§4) | Per feature: Classic regression with the feature off, plausibility with it on |
| 9 | Classic → Modern conversion of worlds and careers | Converted careers playable |
Steps 1 to 4 are the actual split and the risky part; they are pure refactoring and must be done in small commits with the regression after each.
Steps 1 to 4 are the actual split and the risky part; they are pure refactoring and must be done in small commits with the regression after each. Classic improvements continue in parallel on `bmh_season_classic`.
## 8. Tests
- **Match contract tests:** a fixed `MatchdaySetup` with fixed seeds yields a fixed `MatchdayResult` (golden files with synthetic teams, public).
- **Classic regression:** unchanged scripts and expected outputs; run after every step.
- **Extended identity:** Classic regression through the Extended engine with no extensions.
- **Extended identity:** the Classic regression through the Extended engine with no features.
- **Feature tests:** each module in `bmh_features` is tested once against fake ports, then through both adapters (Modern and Classic Extended).
- **Modern plausibility:** bulk season simulations with goal, points and money distributions compared to Classic as a reference band.
- **Dependency check:** the build fails if `bmh_match` includes season or `GameState` headers.
- **Dependency checks:** the build fails if `bmh_match` includes season or `GameState` headers, if `bmh_features` includes `GameState` or OBW model headers, or if a season engine includes interface headers.
## 9. Open decisions
- Whether Classic Extended may change the save layout for its extensions only in OBW saves or also offer a legacy `.FBM` export (proposal: OBW only).
- Whether Modern keeps `bmh-classic@1` as its only player attribute set at first (proposal: yes, richer attributes later).
- Which team owns which variant: Classic and the split (engine/integration), Modern interface (UI), Classic Extended extensions (both, per module).
- Which features become the first backport candidates (proposal: features of interface cost 1 or 2 that do not change league structure).
- Whether Modern keeps `bmh-classic@1` as its only player attribute set at first (proposal: yes, richer attributes later as a new match engine version).
- Ownership: the split and Classic (engine/integration), the Modern interface (UI), Modern features and their backports (shared, per feature).
+6 -3
View File
@@ -26,7 +26,7 @@ Some calendar operations need synchronous human decisions. Their presenters own
## Calendar and matches
The planned split into one shared match engine and three season engines (Classic, Classic Extended, Modern) is described in [ENGINE_SPLIT](ENGINE_SPLIT.md).
The planned split into one shared match engine and the season engines of Classic, Classic Extended (Classic plus backported Modern features) and Modern is described in [ENGINE_SPLIT](ENGINE_SPLIT.md).
The turn driver moves between manager desks, match clocks and calendar events. Weekly, monthly and seasonal processing can produce decisions as well as simulation results. Match groups contain the day's competitions; a manager can intervene only in a group involving that manager's team. A multi-client match clock advances at a barrier shared by all seats.
@@ -57,8 +57,11 @@ of `OpenBMH`, keeping edition-specific process globals isolated. Portable mod co
personal files have independent lifetimes. See [runtime-0.2](formats/obw/runtime-0.2.md).
The launcher layout and theme live in `assets/launcher/launcher.rml` and `theme.rcss`.
They share the same RmlUI core, FreeType font engine and upstream SDL2/OpenGL renderer
on all desktop platforms. The C++ view translates events into the existing launcher
They share the same RmlUI core, FreeType font engine and SDL2 platform layer.
Windows uses the pinned upstream Direct3D 11 renderer with hardware-to-WARP
fallback, while Linux/macOS keep the upstream OpenGL renderer. Both the editor
and launcher share window/device lifetime, resizing and capture through
`src/launch/rml_video.*`. The C++ view translates events into the existing launcher
interface; it does not own conversion rules or mod storage. This presentation layer
can be reused by future modern screens. Classic game screens retain their current UI.
The operating system supplies the folder picker through nativefiledialog-extended.
+16
View File
@@ -469,6 +469,22 @@ A resolver looks a key up in the active packs by priority (§9.5), then in the w
Asset metadata sits next to the files in `assets/index.json`: key, files per size, author, source and licence (required).
**Optional visual defaults (1.1).** A world may set
`manifest.presentation: "assets/presentation.json"`. The referenced document has
`schema: "asset-presentation@1"`, an optional `player_photo_fallback` asset key,
`trophy_fallback` (normally `asset:comp/generic/trophy`), and
`youth_photos: {assets: [<photo keys>], selection: "random-on-creation",
fallback: <photo key>}`. All keys resolve through the normal asset index. A
client supporting youth creation chooses once using its saved game RNG and
persists the selected key; it does not reroll a face on display or rename. This
document supplies pictures, never player records, ratings or generation rules.
Readers without this optional feature retain it and use their existing visual
fallbacks. The current editor preserves it without generating youth players.
An explicitly indexed player `photo` is displayed before composing a retained
`appearance` recipe. A visual overlay can therefore keep Classic appearance and
all game data intact while displaying a supplied photo or silhouette. Sealed
Classic rendering and runtime capabilities are unaffected.
**Player pictures** (`asset:player/<key>/photo`) resolve in this order:
1. A photo from an active pack.
+21
View File
@@ -126,6 +126,27 @@ the current edition's selection and qualification algorithm, including FA Cup
qualifying/proper rounds and League Cup for English data, or indoor/Masters for
German data. The generic `format` field alone is insufficient to execute a stage.
For inspection, `classic-season-entrants@1` assigns each first-division champion
to the Champions League. A holder in that league also qualifies (or the
runner-up if already champion). Domestic cup winners, with finalists as
replacements, enter the Cup Winners' Cup. Title-holder overlap affects the
remaining allocation. The regular UEFA-Cup quotas are `[4,4,4,4,3]` for source
league indices `[0,5,6,7,8]`, taking the next unqualified clubs by rank. Foreign
cup representatives follow the Classic selection procedure. The historical
`x-legacy.europe_places` field is a prediction/colouring value, not that quota.
The versioned Classic ladder uses its first four domestic groups. Relegation
counts come from each league's `x-legacy.relegation_places`. A single lower
league supplies the corresponding top-ranked clubs; parallel lower leagues
supply champions plus winners of the Classic playoffs. Without that playoff
result only the champions are exchanged. The last domestic group draws from
the newcomer pool, never a foreign league named by an unused `below` entry.
License withdrawals and the Classic protection of a human manager at the
bottom tier can affect the actual result. Foreign Classic leagues have no
regular promotion/relegation. These are compatibility policy summaries, not
independent typed modern rule declarations or permission to simulate them in
the editor.
`classic-calendar@1` retains the complete source day table and bindings.
`classic-season-calendar@1` applies options, season cycle, weekday alignment and
leap-year behavior using the Classic calendar algorithm at runtime. Cup series
+50 -1
View File
@@ -2,7 +2,7 @@
This additive profile is a native editing interchange. It does **not** change
`classic-installation-v1`, its seals, the Classic runtime or save files.
It is implemented by OpenBMH Editor 0.5.0, whose application version is separate
It is implemented by OpenBMH Editor 0.5.x, whose application version is separate
from the OBW format version and the OpenBMH 0.2.0 game version.
## Identification
@@ -61,6 +61,55 @@ Competition `trophy` and optional fallback remain logical asset references;
images are indexed just like crests and portraits. Arbitrary new competitions
can use their own trophy or a package-supplied generic trophy.
### Read-only comparisons (Editor 0.5.1)
The editor's `compare` command / `editor_compare` MCP tool projects ratings and
salaries without writing an additional OBW table. Player attributes retain their
set and range. Club and league attributes are player-weighted means of known
values within one set; mixed sets require a filter. Full rosters include reserves,
except source evidence explicitly marked
`x-simulation.squad_role: "source-only-duplicate"`. League membership uses a club's
explicit league, or an unambiguous league `members` reference as fallback.
`contracts.salary` is per season, in integer `manifest.currency` minor units.
Only contracts active on `manifest.start_date` and matching the player's current
team count; absent bounds are open and explicit date bounds are inclusive.
Multiple matching active contracts are ambiguous, not summed. Missing or invalid
salary remains null, independently of an explicit zero. Club/league payrolls
exclude staff and use known player salaries only. `salary_known`,
`salary_unknown`, `salary_ambiguous`, `salary_complete` and `salary_overflow`
describe coverage; a missing/empty/overflowed sum is null. Means of known salaries
round to the nearest minor unit. Attribute means separately report their sample
sizes in `attribute_counts`. No current date, invented contract or foreign-club
strength-band interpretation is substituted for missing data.
### Read-only regulations (Editor 0.5.2)
The `regulations` command / `editor_regulations` MCP tool exposes the same
read-only projection as the Regulations page. It accepts `language` (de/en),
`search`, `nation` and `competition`. It returns `items`, all preserved `rules`,
the world date, `read_only: true` and the session revision. It creates no table,
edits, undo entries or runtime entrants.
Each item retains its full `record` and `stages`. Explicit `movement` entries
retain rank ranges and destination references; tier comparisons label promotion
and relegation, participant roles label playoffs. Competition/stage `slots`
retain their full selector, fallback, explicit destination and phase; they are
visible on both the source and destination competition. Fixed participant lists
are not reinterpreted as qualification rules.
Imported `classic_runtime.qualifications: classic-season-entrants@1` and
`legacy_ladder` records permit a labelled presentation of the existing Classic
policy, documented in [classic-v1](classic-v1.md). Explicit declared rules take
precedence. Unknown rules stay unspecified; the editor never substitutes modern
UEFA quotas or infers qualification from historical colouring fields. This
presentation registry does not implement a new season engine.
Optional `manifest.presentation` references the `asset-presentation@1` visual
defaults described in [OBW §9.2](../OBW.md#92-resolution-and-image-formats).
Youth pools, silhouette and generic trophy keys remain indexed assets. They are
preserved across editor saves, independent of Classic source recipes or seals.
## Sources, conflicts and images
- `x-source/` can contain unchanged or losslessly gzipped normalized source
+51
View File
@@ -0,0 +1,51 @@
# Editor 0.5.1 — ratings and salaries
These are actual 1440×900 SDL2/OpenGL/RmlUI captures on Linux under Xvfb
with software OpenGL. All content is the synthetic `World::demo()` fixture:
52 invented players, two invented clubs, one league and 50 explicitly synthetic
per-season contracts (one unknown salary per club). No real-world data, original
game images, personal paths, settings or credentials are included. This editor
uses starting worlds, not a career save; reproduce the data with `--demo`.
| View | Evidence |
|---|---|
| Before, released Editor 0.5.0 | [Player inspector](before-players-0.5.0.png), without a ratings/payroll overview |
| Players, Midnight Glass / German | [Salary descending](players-midnight-de.png) |
| Teams, Silver Glass / English | [Player-weighted means, payroll and coverage](teams-silver-en.png) |
| Leagues, Matchday / German | [League aggregate](leagues-matchday-de.png) |
| Attribute selection | [Choose columns](columns-midnight-de.png) |
| Horizontal navigation | [Further attributes](players-scroll-midnight-de.png); header and values remain aligned |
The after views use Editor 0.5.1. The before capture uses the released 0.5.0
Linux executable and its own assets. No screenshot is a browser mockup.
Validation:
- `editor_core_tests`, `editor_comparison_tests`, `editor_version` pass locally.
The comparison suite checks 36 outcomes, including actual currency units,
unknown versus zero salaries, date/team selection, conflicting contracts,
staff exclusion, complete reserves, duplicate evidence, player-weighted means,
coverage, empty groups, numeric sorting across more than 200 rows, stable ties,
nulls last in both directions, different rating systems, overflow, read-only
session state, cache refresh after editing/undo and the shared MCP tool.
- `tests/editor_gui_smoke.py` performs real keyboard/mouse operations. It selects
a rating column via its label, sorts ratings and salaries, opens the first row
and edits it. MCP verifies the expected stable player/club/league identifier
changed, then undoes it. The existing inspector/search/JSON/undo/save checks
still pass. The comparison leaves the saved world clean.
- All three themes and both languages were inspected. Header arrows do not rely
on missing font glyphs; horizontal scrolling keeps column alignment.
- The completed private season was checked independently: 18,920 eligible
player rows, 545 teams, 32 leagues; 832 source-only duplicate rows excluded.
Every eligible player has one known current-team salary in that package.
These are dataset estimates, not verified real wages. No private rows or
screenshots are distributed in this public directory.
Build the targets and run the CTest commands in [the editor guide](../../EDITOR.md).
For the native input test, run `python3 tests/editor_gui_smoke.py <OpenBMHEditor>`
inside a graphical session or Xvfb with xdotool. `OpenBMHEditor --demo --page
comparison` opens the overview; the three buttons choose players, teams or
leagues. **Choose columns** selects additional attributes.
Windows/macOS native build and core tests run in the editor CI. The Linux
window checks do not establish human acceptance on those operating systems.
Binary file not shown.

After

Width:  |  Height:  |  Size: 203 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 130 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 137 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 189 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 184 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 149 KiB

+31
View File
@@ -0,0 +1,31 @@
# Dropdown chevron alignment — Editor 0.5.5
The old chevron was too low and too far inside the button. RmlUI positions its
native `selectarrow` from the select's content box, which already excludes the
reserved right padding. The correction moves the existing glyph 28dp right and
8dp up, into that padding and onto the control's vertical center. Size, colour,
selected values and native select events stay the same.
These are actual SDL2/RmlUI captures with software OpenGL. All data comes from
`OpenBMHEditor --demo --page clubs`: generated clubs and project-authored
geometric crests. No original installation or savegame is involved. Temporary
MCP profiles use an automatically assigned localhost port; no token is visible
or included. Images are captured directly, without image generation or retouching.
| View | Native capture |
|---|---|
| Before: 0.5.4, Midnight / German | [Before](before-0.5.4.png) |
| After: 0.5.5, Midnight / German | [After](after-midnight-1440x900.png) |
| After: Silver / English | [Silver](after-silver-1440x900.png) |
| After: Matchday / German | [Matchday](after-matchday-1440x900.png) |
| Toolbar and inspector controls | [Main view](after-toolbar.png) |
| Click directly on the repositioned theme arrow | [Native open list](after-dropdown.png) |
| Small window, 1080×720, editor scale 0.78× | [Small](after-midnight-1080x720.png) |
| Large window, 2560×1600, editor scale 1.78× | [Large](after-midnight-2560x1600.png) |
[Capture parameters](native-captures.json) record the themes, languages, native
viewports and editor scales. The arrow remains inside the button at each scale.
Clicking its new position opens the native option list; Escape dismisses it.
The existing native GUI smoke verifies selection changes, all themes, both
languages, draft protection and navigation. This layout-only correction adds
no editor data or engine behaviour.
Binary file not shown.

After

Width:  |  Height:  |  Size: 117 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 106 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 78 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 114 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 226 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 119 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 143 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 114 KiB

@@ -0,0 +1,65 @@
{
"editor": "0.5.5",
"cases": [
{
"theme": "midnight",
"language": "de",
"viewport": [
1440,
900
],
"scale": 1.0,
"data": "generated demo",
"capture": "after-midnight-1440x900.png"
},
{
"theme": "silver",
"language": "en",
"viewport": [
1440,
900
],
"scale": 1.0,
"data": "generated demo",
"capture": "after-silver-1440x900.png"
},
{
"theme": "matchday",
"language": "de",
"viewport": [
1440,
900
],
"scale": 1.0,
"data": "generated demo",
"capture": "after-matchday-1440x900.png"
},
{
"theme": "midnight",
"language": "de",
"viewport": [
1080,
720
],
"scale": 0.78,
"data": "generated demo",
"capture": "after-midnight-1080x720.png"
},
{
"theme": "midnight",
"language": "de",
"viewport": [
2560,
1600
],
"scale": 1.7777777777777777,
"data": "generated demo",
"capture": "after-midnight-2560x1600.png",
"window_position": [
0,
0
],
"fully_inside_capture_display": true
}
]
}
+27
View File
@@ -0,0 +1,27 @@
# Native read-only image preview
Editor 0.5.3, captured from the native RmlUI application at 1440×900.
All pictures and records are authored synthetic demo data. No game installation,
real crest, portrait, savegame or personal profile is included.
| View | Native screenshot |
|---|---|
| Before: small image in the club inspector | [Club inspector](before-club-image.png) |
| After: large read-only preview, Midnight / German | [Midnight](preview-midnight-de.png) |
| Silver / English | [Silver](preview-silver-en.png) |
| Matchday / German | [Matchday](preview-matchday-de.png) |
| Jump to the exact linked image record | [Linked asset](linked-asset.png) |
Clicking the inspector image or a list thumbnail opens the same viewer. Images
retain their aspect ratio; there are no editing controls. Close, the window's
close button and Escape return to the current form. **View asset** opens the
linked asset, clearing unrelated country/league/team filters. Composed Classic
portraits without a single backing asset offer the general image library.
`tests/editor_gui_smoke.py` exercises the actual mouse and keyboard path. MCP
observes that opening/closing the preview leaves the world and history unchanged.
The test also preserves a pending property draft, cancels a guarded asset jump,
checks the selected club's exact asset, and opens the different asset from an
unselected row. These checks complement the core, comparison and regulations
tests. The synthetic demo starts unsaved; the asterisk in these captures reflects
that initial state rather than a modification caused by the preview.
Binary file not shown.

After

Width:  |  Height:  |  Size: 141 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 128 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 83 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 88 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 92 KiB

+64
View File
@@ -0,0 +1,64 @@
# Native navigation, pickers and idle rendering
Editor 0.5.4, native SDL2/RmlUI at 1440×900. The captures contain only generated
demo records and project-authored geometric crests. No installation, real photo,
savegame, personal profile or MCP token is included. Reproduce the initial
database with `OpenBMHEditor --demo --page clubs`.
| View | Screenshot |
|---|---|
| Before: 0.5.3 controls and MCP button spacing | [Options before](before-options-0.5.3.png) |
| After: Modern Desktop controls and separated Copy connection | [Options](options-midnight-de.png) |
| Native dropdown, Midnight / German | [Midnight](dropdown-midnight-de.png) |
| Native dropdown, Silver / English | [Silver](dropdown-silver-en.png) |
| Native dropdown, Matchday / German | [Matchday](dropdown-matchday-de.png) |
| Browser context menu, both directions available | [Back / Forward](history-midnight-de.png) |
The controls port the Modern Desktop submenu palettes, gradient buttons, rounded
popup, selection checkmark, matching text size and hover treatment to RCSS. They
retain RmlUI's native select values/events and scale with the editor. Escape
cancels the open list before closing its dialog. The connection action now has
20dp of space above it. Correct frame initialization preserves transparent
offscreen layers for the popup shadows.
`tests/editor_gui_smoke.py` uses actual mouse/keyboard input and an MCP observer:
- Drill from the second of two leagues to its club and players. Back twice,
then Forward twice; edit/undo the selected destinations to verify their IDs.
- Cancel a draft when going Back, then apply it to the original player. The
subsequent Back still visits the club, proving the cursor did not advance.
- Navigate elsewhere after Back, verify that Forward stays unavailable, and
exercise both mouse side buttons.
- Follow a preview's exact image-asset link and return in both directions.
- Reopen the same OBW through MCP. Its unchanged filename/IDs must not preserve
history or unapplied fields from the previous world.
- Change native dropdowns by keyboard, cancel one with Escape, apply both
languages and all three themes. Options alone leaves the world untouched.
- Leave the window idle for three seconds. Its CPU budget is 20% of one logical
core, intentionally generous for software-rendered CI. Continuous repainting
fails this check. The observed local idle use was below 1% of one core.
The core tests also verify that edits, undo and save retain `world_generation`,
while opening another world increments it. Navigation does not alter data or
the editing undo cursor. Scroll positions are restored after rebuilding a view;
history is limited to the last 200 visited views in the current world.
## Idle measurement
The former loop updated/rendered/presented continuously, with only a 10ms delay
after each frame. The new loop waits for input or the next requested RmlUI timer.
MCP state is checked every 400ms without repainting an unchanged screen. Async
work completion, resize/expose, screenshot and automated-exit deadlines still
wake the loop. Minimized windows do not render.
[Measured CPU time](idle-cpu-linux.json) uses six-second idle samples after the
window settles, software OpenGL and two renderer threads. The synthetic demo
changed from 95.3% to below the 0.01s sampling resolution; a private supplied world
changed from 136.0% to 0.17% of **one logical core**. Multithreaded rendering can
exceed 100% on this scale; these figures are not Task Manager's whole-machine
percentage. This measurement is separate from import or image-processing work.
Native startup, screenshot deadlines, Unicode paths and failure reporting are
covered by `tests/editor_startup_smoke.py`. Windows/WARP runtime measurements
with private data are kept in the private repository. Build success on macOS
does not establish native human acceptance there.
Binary file not shown.

After

Width:  |  Height:  |  Size: 112 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 109 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 117 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 122 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 145 KiB

@@ -0,0 +1,40 @@
{
"environment": {
"os": "Debian 13 x64",
"renderer": "Mesa software OpenGL",
"display": "Xvfb 1600x1000",
"window": "1440x900",
"software_renderer_threads": 2,
"cpu_unit": "percent of one logical core; sums all editor threads"
},
"before_version": "0.5.3",
"after_version": "0.5.4",
"before": [
{
"case": "demo",
"duration_s": 6.000090104993433,
"cpu_s": 5.720000000000001,
"one_core_percent": 95.33190168660411
},
{
"case": "diamond",
"duration_s": 6.000068283872679,
"cpu_s": 8.16,
"one_core_percent": 135.99845224983366
}
],
"after": [
{
"case": "demo",
"duration_s": 6.000068521825597,
"cpu_s": 0.0,
"one_core_percent": 0.0
},
{
"case": "diamond",
"duration_s": 6.000067526940256,
"cpu_s": 0.010000000000000009,
"one_core_percent": 0.1666647909394367
}
]
}
Binary file not shown.

After

Width:  |  Height:  |  Size: 114 KiB

+41
View File
@@ -0,0 +1,41 @@
<!-- SPDX-License-Identifier: GPL-3.0-only -->
# Editor 0.5.2: read-only regulations
Native 1440×900 SDL2/OpenGL/RmlUI captures on Linux with software OpenGL. All
records and artwork are synthetic. No installation, real club/player data,
savegame, private archive or user profile is included.
| View | Capture |
|---|---|
| Before: competition inspector, released 0.5.1 | [Before](before-competitions-0.5.1.png) |
| Promotion/relegation, Midnight Glass / German | [After](rules-midnight-de.png) |
| International qualification and replacement | [Qualification](qualification-midnight-de.png) |
| Preserved game rule and attribute ranges | [Game rules](game-rules-midnight-de.png) |
| Silver Glass / English | [Silver](rules-silver-en.png) |
| Matchday / German | [Matchday](rules-matchday-de.png) |
Create the display fixture using the editor's own synthetic demo:
```sh
python3 docs/qa/editor-regulations/make_fixture.py PATH/TO/OpenBMHEditor TEMP/synthetic.obw
OpenBMHEditor --open TEMP/synthetic.obw --page regulations
```
The recipe adds synthetic upper/lower leagues, explicit rank ranges, a playoff,
an international qualification selector and fallback. It is a display fixture,
not a playable season. Options selects the language/theme. Scroll the right
panel to qualification; select **Game rules** and `demo@1` to inspect the stored
attribute ranges. Before was captured with the same fixture in the 0.5.1
competition inspector, which had no dedicated rule view.
Validation: existing editor core/MCP tests, comparisons, version and new
regulations tests; native mouse/keyboard integration and package-boundary
checks. The regulations tests cover declared movement, both slot locations,
explicit destinations, fallback preservation, language/filtering, parallel
Classic champions/playoffs, the bottom newcomer pool, foreign closed leagues,
the named UEFA quotas, declared-rule precedence, null extensions and unchanged
revision/history. The GUI test switches both rule tabs, searches and verifies
the shared read-only MCP projection without changing the world.
Actual Diamond source identity, unchanged game data, images, round-trip checks
and captures are recorded separately in the private content repository.
Binary file not shown.

After

Width:  |  Height:  |  Size: 187 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 152 KiB

@@ -0,0 +1,54 @@
#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-3.0-only
"""Make a synthetic display fixture; no real-world or installed game data."""
import argparse
import json
from pathlib import Path
import subprocess
import tempfile
import zipfile
def main():
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument('editor', type=Path)
parser.add_argument('output', type=Path)
args = parser.parse_args()
with tempfile.TemporaryDirectory(prefix='obw-rule-fixture-') as temporary:
root = Path(temporary)
settings = root / 'settings.json'
settings.write_text('{"mcp_enabled":false}')
subprocess.run([str(args.editor.resolve()), '--headless', '--demo', '--settings', str(settings),
'--output', str(root / 'demo.obw')], check=True)
with zipfile.ZipFile(root / 'demo.obw') as source:
docs = {file: source.read(file) for file in source.namelist()}
comps = json.loads(docs['world/competitions.json'])
league = comps['items'][0]
league.update({'tier': 2, 'stages': [{'id': 'regular', 'format': 'league', 'teams': 18, 'legs': 2,
'points': {'win': 3, 'draw': 1, 'loss': 0}, 'tiebreakers': ['points', 'goal_difference', 'goals_for']}],
'movement': [{'ranks': [1, 2], 'to': 'comp:upper'},
{'ranks': [3], 'to': 'comp:playoff', 'role': 'challenger'},
{'ranks': [16, 18], 'to': 'comp:lower'}]})
clubs = json.loads(docs['world/clubs.json'])
for i in range(16):
club_id = 'club:fixture-' + str(i)
clubs['items'].append({'id': club_id, 'name': 'Testverein ' + str(i + 1), 'type': 'club',
'nation': 'nation:de', 'competition': 'comp:demo'})
league['members'].append(club_id)
for code, title, tier in [('upper', 'Oberliga (Demo)', 1), ('lower', 'Unterliga (Demo)', 3)]:
comps['items'].append({'id': 'comp:' + code, 'name': title, 'nation': 'nation:de', 'type': 'league',
'tier': tier, 'stages': [{'id': 'regular', 'format': 'league', 'teams': 18}]})
comps['items'].append({'id': 'comp:playoff', 'name': 'Relegation (Demo)', 'type': 'cup'})
comps['items'].append({'id': 'comp:international', 'name': 'Internationaler Demo-Pokal',
'type': 'club_international', 'slots': [{'from': 'comp:demo', 'ranks': [1, 4], 'stage': 'main',
'fallback': {'from': 'comp:upper', 'next_unqualified': True}}]})
for key, value in [('world/competitions.json', comps), ('world/clubs.json', clubs)]:
docs[key] = json.dumps(value, ensure_ascii=False).encode()
args.output.parent.mkdir(parents=True, exist_ok=True)
with zipfile.ZipFile(args.output, 'w', zipfile.ZIP_DEFLATED) as output:
for file, data in docs.items():
output.writestr(file, data)
if __name__ == '__main__':
main()
Binary file not shown.

After

Width:  |  Height:  |  Size: 165 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 139 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 158 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 147 KiB

+12 -2
View File
@@ -1,5 +1,14 @@
<!-- SPDX-License-Identifier: GPL-3.0-only -->
# OpenBMH v0.2.0
# OpenBMH v0.2.1
Fixes the launcher startup on Windows Server / Remote Desktop and computers
without an OpenGL 3.3 driver. The Windows RmlUI launcher uses Direct3D 11, with
automatic WARP software fallback; Linux and macOS keep their existing OpenGL
renderer. Launch errors use a native Windows dialog and a diagnostic log under
`%LOCALAPPDATA%/OpenBMH/OpenBMH-startup.log`. Game rules, saves and OBW content
remain compatible with 0.2.0.
## Version 0.2.0
Version 0.2 makes the original-style game independent of the original installation
after import. It supports Bundesliga Manager Hattrick and Football Limited Classic
@@ -52,7 +61,8 @@ See the [runtime and migration contract](../../formats/obw/runtime-0.2.md).
The build pipeline produces Windows x64, Linux x64 and macOS ARM64 ZIPs and a
matching source ZIP with pinned dependency sources and build information.
Builds and automated tests do not replace native interactive acceptance.
The launcher requires OpenGL 3.3 (macOS: 4.1). Linux requires the platform libraries
The launcher uses Direct3D 11 with WARP fallback on Windows, OpenGL 3.3 on Linux,
and OpenGL 4.1 on macOS. Linux requires the platform libraries
described in [BUILDING](../../BUILDING.md), including GTK3 for its folder picker.
The macOS executable is unsigned and is not a notarised application bundle.
+84 -1
View File
@@ -1,5 +1,88 @@
<!-- SPDX-License-Identifier: GPL-3.0-only -->
# OpenBMH Editor 0.5.0
# OpenBMH Editor 0.5.5
Centers the dropdown chevron vertically and moves it into the reserved right
padding. This fixes its low, inset position in toolbar filters, inspectors and
Options across all three themes and editor scales. Native select behavior is
preserved. [Before/after native captures](../../qa/editor-dropdown-arrow/README.md)
use synthetic data.
## Editor 0.5.4
Adds browser-style **Back / Forward** navigation. Right-click anywhere in the
editor to open the context menu; Alt+Left/Right and mouse side buttons use the
same history. Returning to a view restores its filters, selected record, sorting,
page and scroll positions. Unapplied inspector entries retain their confirmation
dialog. Opening another world clears navigation; it does not undo data edits.
The editor now updates and renders on demand, instead of redrawing the entire
window continuously while idle. Input, timed caret/animation updates and external
MCP changes remain active. Minimized windows do not render. This is especially
useful with Windows software rendering over Remote Desktop.
Dropdowns follow the Modern Desktop pickers: rounded themed buttons and popup
lists, equal label/option font sizes, a checkmark for the current selection and
subtle hover surfaces. Escape closes the open list before its dialog. Options
also gives **Copy connection** more space below the MCP URL. All three themes
and both interface languages are supported.
[Native screenshots and verification](../../qa/editor-navigation/README.md)
include the controls and navigation.
## Editor 0.5.3
Fixes the Windows graphical startup on machines without an OpenGL 3.3 driver,
including Windows Server / Remote Desktop. The editor and game launcher use the
pinned RmlUI Direct3D 11 renderer with automatic WARP software fallback. No
additional graphics runtime download is needed on the supported Windows systems.
Linux/macOS retain their existing OpenGL rendering.
Windows also builds WebP without an AVX requirement, avoiding illegal instructions
when displaying imported club images on older CPUs or virtual machines.
Double-click a country to see its competitions, a league to see its clubs, and
a club to see its players. Destination lists inherit the corresponding filters;
unapplied inspector entries are protected by the existing confirmation dialog.
Windows startup failures now produce a native dialog and a log in
`%LOCALAPPDATA%/OpenBMH/OpenBMHEditor-startup.log`. Console redirection is
retained and headless/MCP errors remain nonmodal. Native GUI startup, screenshots,
Unicode paths and the actual launcher are now tested on Windows Server 2022
with WARP forced, in addition to the existing core/MCP tests.
## Editor 0.5.2
Adds **Regulations / Regelwerk**, a read-only view of game and league rules.
Inspect promotion/relegation places and destinations, playoff conditions,
international qualification selectors and replacement rules. Search competitions
and filter by country; inspect preserved game-rule records and stage details.
Both interface languages and all three themes are supported. The read-only MCP
tool `editor_regulations` returns the same projection.
Explicit OBW declarations take precedence. Imported worlds show the named
Classic ladder and qualification policy, clearly labelled. The parallel third
divisions retain champion-plus-playoff promotion; the bottom tier uses its
newcomer pool. Historical display/colouring quotas are not reinterpreted as
European qualification rules. Undeclared rules stay unspecified.
This adds no season simulation or rule editing.
## Editor 0.5.1
Adds **Ratings & salaries / Wertevergleich**: sortable player, team and league
overviews, searchable and filterable by country/league/club and attribute system.
Choose the attribute columns and scroll horizontally for additional metrics.
Click a row to open its existing editor. All three themes and both interface
languages are supported.
Player values retain their native scales. Group ratings are player-weighted
means; salaries are per-season amounts from contracts active at the world start
date. Partial wage bills are marked, unknown values stay unknown, explicit zero
salaries remain zero. All reserves are included; source-only duplicate evidence
is excluded. Different rating systems are not combined. The read-only MCP tool
`editor_compare` exposes the same results and pagination. Comparison caches
refresh after edits and undo/redo without changing the world.
## Initial editor 0.5.0
The first standalone editor release uses SDL2, RmlUI and OpenGL on Windows x64,
Linux x64 and macOS ARM64. Its version is independent of OpenBMH 0.2.0.