Bind native manager actions and preserve ongoing Modern standings (by Codex)

This commit is contained in:
Codex committed 2026-10-29 21:24:49 +01:00
1 parent f9f950fc7f
commit cf424b6be1
31 files changed
+466 -100

No files matched your search

+27 -1
View File
@@ -15,7 +15,7 @@ using namespace bmh::modern_ui;
int main(int argc, char **argv) {
try {
const std::string mode=argc>1?argv[1]:"";
const std::set<std::string> modes{"prepare","prepare-two","prepare-national","prepare-almanac","inspect","inspect-friendlies","inspect-almanac","verify","verify-lineup","verify-sports","verify-bank","verify-commerce","verify-contracts","verify-calendar","verify-friendlies","verify-national","verify-almanac","verify-shootouts","verify-reports","verify-fixtures","verify-other","verify-rankings","prepare-rankings-archived","verify-create","inspect-coach-identity","prepare-coach-identity","verify-coach-almanac","verify-files","verify-statistics","prepare-statistics","inspect-statistics","prepare-toto","verify-toto","settle-toto","verify-stadium","complete-stadium","verify-transfer","prepare-achievements","verify-balance","verify-balance-warning","verify-settings"};
const std::set<std::string> modes{"prepare","prepare-two","prepare-national","prepare-almanac","inspect","inspect-friendlies","inspect-almanac","verify","verify-lineup","verify-sports","verify-bank","verify-commerce","verify-contracts","verify-calendar","verify-friendlies","verify-national","verify-almanac","verify-shootouts","verify-reports","verify-fixtures","verify-other","verify-rankings","prepare-rankings-archived","verify-create","inspect-coach-identity","prepare-coach-identity","verify-coach-almanac","verify-files","verify-statistics","prepare-statistics","inspect-statistics","prepare-toto","verify-toto","settle-toto","verify-stadium","complete-stadium","verify-transfer","prepare-achievements","verify-balance","verify-balance-warning","verify-settings","verify-managers"};
if(argc!=4||!modes.contains(mode))throw std::runtime_error("usage: modern_engine_bridge_probe <prepare[-two|-national|-almanac]|inspect[-friendlies|-almanac]|verify[-lineup|-sports|-bank|-commerce|-contracts|-calendar|-friendlies|-national|-almanac|-shootouts]> <world.obw> <new-output-directory>");
const fs::path world = argv[2], out = argv[3]; fs::create_directories(out);
const auto write = [&](const char *file, const Json &j) { editor::write_atomic(out / file, j.dump(2)); };
@@ -285,6 +285,32 @@ int main(int argc, char **argv) {
link = EngineBridge::open(world, out / "lineup.obs"); const auto loaded = link->snapshot(); write("lineup-loaded.json", loaded);
if (loaded.at("lineup").at("data").at("order") != order) throw std::runtime_error("lineup lost during OBS round trip");
}
if(mode=="verify-managers") {
Json log=Json::array();const auto initial=engine_manager_projection(before);const auto old_owner=before.at("desktop").at("meta").at("scope").at("managerId");
if(initial.at("can_join")!=true||initial.at("people").size()!=1)throw std::runtime_error("one-manager club fixture required");
link->save_copy(out/"read-only.obs");if(link->snapshot()!=before)throw std::runtime_error("manager read changed source");
auto tables=[&](){Json all=Json::object();const auto index=link->read({{"kind","report-index"}});for(const auto &l:index.at("data").at("leagues")){const auto read=link->read({{"kind","league-report"},{"leagueId",l.at("id")},{"filter",0}});for(auto row:read.at("data").at("table")){const auto id=row.at("team").at("id").get<std::string>();row.erase("original");all[id]=row;}}return all;};
auto choose=[&](const Json &value,int ordinal){auto candidate=value.at("draft_managers");std::set<std::string> used;std::set<int> portraits;for(const auto &p:candidate){used.insert(p.at("club").get<std::string>());portraits.insert(p.at("portrait").get<int>());}std::string club;bool promoted=false;
std::string top;for(const auto &league:modern::current_world()->leagues)if(league.index==0)top=league.id;
for(const auto &[id,c]:value.at("clubs").items())if(c.at("playable")==true&&!used.contains(id)&&c.at("leagueId")==top){club=id;const auto *record=modern::current_world()->club(id);if(record&&record->competition!=c.at("leagueId").get<std::string>()){promoted=true;break;}}
if(club.empty())throw std::runtime_error("no available club");int portrait=0;while(portraits.contains(portrait))++portrait;
const std::array<const char*,3> names{"Mina Öztürk","Zoë García","山田 太郎"};candidate.push_back({{"name",names.at(size_t(ordinal))},{"club",club},{"portrait",portrait},{"portrait_style",ordinal%2?"painted":"photo"},{"strength_choice",1}});return std::make_pair(candidate,promoted);};
const auto original_tables=tables();const auto first=choose(initial,0);const auto valid=engine_manager_command(before,first.first,"request:manager-join");
auto bad=valid;bad["requestId"]="request:invalid-batch";bad["payload"]["managers"].push_back({{"name","Invalid second"},{"club",initial.at("draft_managers")[0].at("club")},{"portrait",11},{"portrait_style","photo"},{"strength_choice",1}});
const auto refused=link->command(bad);write("invalid.json",refused);if(refused.value("messageType","")!="error"||link->snapshot()!=before||tables()!=original_tables)throw std::runtime_error("failed manager draft changed source");link->save_copy(out/"failed-unchanged.obs");
for(int n=0;n<3;++n){const auto current=link->snapshot(),view=engine_manager_projection(current);const auto selection=choose(view,n);const auto prior_tables=tables();const auto command=engine_manager_command(current,selection.first,"request:add-"+std::to_string(n));const auto response=link->command(command);log.push_back({{"command",command},{"response",response},{"currentMembershipDiffersFromInitialWorld",selection.second}});if(response.value("messageType","")!="command_result")throw std::runtime_error(response.dump());const auto after=link->snapshot(),actual=engine_manager_projection(after);if(actual.at("people").size()!=size_t(n+2)||after.at("desktop").at("meta").at("scope").at("managerId")!=old_owner||after.at("desktop").at("meta").at("date")!=before.at("desktop").at("meta").at("date"))throw std::runtime_error("join changed current owner/date/count");
for(size_t i=0;i<view.at("people").size();++i)if(view.at("people")[i]!=actual.at("people")[i])throw std::runtime_error("join changed existing manager identity");
if(actual.at("people").back().at("name")!=selection.first.back().at("name")||actual.at("people").back().at("teamId")!=selection.first.back().at("club")||actual.at("people").back().at("portraitStyle")!=selection.first.back().at("portrait_style"))throw std::runtime_error("new manager presentation/club lost");
if(tables()!=prior_tables){write("tables-before-failure.json",prior_tables);write("tables-after-failure.json",tables());write("join-failure.json",after);write("join-commands.json",log);link->save_copy(out/"changed-standings.obs");throw std::runtime_error("joining changed existing league standings");}if(link->command(command)!=response||link->snapshot()!=after)throw std::runtime_error("join replay changed state");auto stale=command;stale["requestId"]="request:stale-"+std::to_string(n);if(link->command(stale).value("code","")!="stale_revision"||link->snapshot()!=after)throw std::runtime_error("stale join changed state");
const auto path=out/("managers-"+std::to_string(n+2)+".obs");link->save_copy(path);link->load_same_world(path);if(link->snapshot().at("session").at("data")!=after.at("session").at("data"))throw std::runtime_error("manager OBS roundtrip lost people");write(("after-"+std::to_string(n+2)+".json").c_str(),link->snapshot());
}
const auto full=link->snapshot();if(engine_manager_projection(full).at("can_join")!=false)throw std::runtime_error("fifth manager enabled");auto fifth=valid;fifth["requestId"]="request:fifth";fifth["expectedRevision"]=full.at("desktop").at("meta").at("stateRevision");if(link->command(fifth).value("messageType","")!="error"||link->snapshot()!=full)throw std::runtime_error("fifth manager changed state");
const auto &meta=full.at("desktop").at("meta");Json quit={{"messageType","command"},{"requestId","request:multi-resign"},{"careerId",meta.at("careerId")},{"expectedRevision",meta.at("stateRevision")},{"owner",{{"managerId",meta.at("scope").at("managerId")}}},{"kind","manager.resign.commit"},{"payload",{{"confirmed",true}}}};if(link->command(quit).value("code","")!="resign_not_supported_yet"||link->snapshot()!=full)throw std::runtime_error("unsupported multi-resign changed state");
link.reset();link=EngineBridge::open(world,out/"input.obs");const auto single=link->snapshot();auto no=engine_manager_command(single,Json(),"request:unconfirmed",true);no["payload"]["confirmed"]=false;if(link->command(no).value("code","")!="confirmation_required"||link->snapshot()!=single)throw std::runtime_error("unconfirmed resignation changed source");const auto end=link->command(engine_manager_command(single,Json(),"request:resign",true));write("resign.json",end);if(end.value("outcome","")!="career_ended"||engine_manager_projection(link->snapshot()).at("ended")!=true)throw std::runtime_error("single resignation did not end career");bool end_save_refused=false;try{link->save_copy(out/"ended.obs");}catch(const std::exception &e){end_save_refused=std::string(e.what())=="career_complete";}if(!end_save_refused||fs::exists(out/"ended.obs"))throw std::runtime_error("unexpected ended-save capability");
write("commands.json",log);write("tables-before.json",original_tables);write("receipt.json",{{"status","passed"},{"pureRead",true},{"atomicInvalidBatch",true},{"currentMembershipUsed",first.second},{"oldOwnerAndPeoplePreserved",true},{"standingsUnchanged",true},{"people",4},{"unicodeAndPortraitsPreserved",true},{"replayAndStale",true},{"threeActualObsRoundtrips",true},{"fifthRefused",true},{"multiResignStillRefused",true},{"singleResign",true},{"endedSaveUnavailable",true}});std::cout<<"actual manager joins, current league memberships, standings, identities, resign and OBS passed\n";return 0;
}
if (mode == "verify-settings") {
const auto projected=engine_settings_projection(before);
write("read-only-save.json",link->save_copy(out/"read-only.obs"));
@@ -0,0 +1,22 @@
// SPDX-License-Identifier: GPL-3.0-only
#include "modern/ui/engine_bridge.hpp"
#include <iostream>
#include <stdexcept>
using namespace bmh::modern_ui;
namespace {
void check(bool b,const char *s){if(!b)throw std::runtime_error(s);}
template<class F>void rejects(F f){bool bad=false;try{f();}catch(const std::exception&){bad=true;}check(bad,"invalid manager command accepted");}
}
int main()try{
Json meta={{"contractVersion","bmh-modern-ui@draft1"},{"careerId","career:one"},{"worldId","world:one"},{"worldRevision","1"},{"stateRevision","8"},{"scope",{{"managerId","manager:one"},{"teamId","club:one"},{"role","club"},{"allowedCommands",{"manager.join.commit","manager.resign.commit"}}}}};Json b;
for(auto *kind:{"session","desktop","camps","manager-menu"})b[kind]={{"messageType","snapshot"},{"meta",meta},{"data",{{"kind",kind}}}};
b["desktop"]["data"].update({{"manager",{{"id","manager:one"}}},{"team",{{"id","club:one"}}},{"accounts",{{"cash",{{"minor","0"},{"currency","EUR"},{"minorUnits",2}}}}}});b["camps"]["data"]["camps"]=Json::array();
auto &d=b["manager-menu"]["data"];d.update({{"activeManagerId","manager:one"},{"ownerManagerId","manager:one"},{"ended",false},{"canJoin",true},{"canResign",true},{"joinReason",""},{"resignReason",""},{"surface","outdoor"},{"managers",Json::array({{{"id","manager:one"},{"name","Old Manager"},{"teamId","club:one"},{"portrait",3},{"portraitStyle","photo"}}})},{"clubs",Json::array({{{"id","club:one"},{"leagueId","league:current"},{"playable",true}},{{"id","club:promoted"},{"leagueId","league:current"},{"playable",true}},{{"id","club:foreign"},{"leagueId","league:foreign"},{"playable",false}}})}});
const auto original=b;auto v=engine_manager_projection(b);check(b==original&&v.at("clubs").at("club:promoted").at("leagueId")=="league:current","projection changed source or lost current membership");auto candidate=v.at("draft_managers");candidate.push_back({{"name"," Mina Öztürk "},{"club","club:promoted"},{"portrait",4},{"portrait_style","painted"},{"strength_choice",2}});
const auto cmd=engine_manager_command(b,candidate,"request:join");check(cmd.at("payload").at("managers").size()==1&&cmd.at("payload").at("managers")[0].at("name")=="Mina Öztürk"&&cmd.at("owner").at("managerId")=="manager:one"&&cmd.at("expectedRevision")=="8","join lost normalized name or owner");
const auto quit=engine_manager_command(b,Json(),"request:quit",true);check(quit.at("payload").at("confirmed")==true,"resign lacks explicit confirmation");
auto bad=candidate;bad[0]["name"]="Changed old manager";rejects([&]{engine_manager_command(b,bad,"request:bad");});bad=candidate;bad[1]["portrait"]=3;rejects([&]{engine_manager_command(b,bad,"request:bad");});bad=candidate;bad[1]["club"]="club:one";rejects([&]{engine_manager_command(b,bad,"request:bad");});bad=candidate;bad[1]["club"]="club:foreign";rejects([&]{engine_manager_command(b,bad,"request:bad");});
auto foreign=b;foreign["manager-menu"]["meta"]["worldRevision"]="2";rejects([&]{engine_manager_projection(foreign);});foreign=b;foreign["manager-menu"]["data"]["clubs"].push_back(d.at("clubs")[0]);rejects([&]{engine_manager_projection(foreign);});foreign=b;foreign["manager-menu"]["data"]["canJoin"]=false;rejects([&]{engine_manager_command(foreign,candidate,"request:bad");});foreign=b;foreign["manager-menu"]["data"]["managers"].push_back({{"id","manager:two"},{"name","Second"},{"teamId","club:promoted"},{"portrait",4},{"portraitStyle","photo"}});foreign["manager-menu"]["data"]["canResign"]=false;rejects([&]{engine_manager_command(foreign,Json(),"request:bad",true);});
foreign=b;foreign["manager-menu"]["data"]["ended"]=true;foreign["manager-menu"]["data"]["canJoin"]=false;foreign["manager-menu"]["data"]["canResign"]=false;foreign["manager-menu"]["data"]["activeManagerId"]=nullptr;check(engine_manager_projection(foreign).at("active").at("id")=="manager:one","archived view owner lost on game end");
std::cout<<"manager ownership, current membership, immutable participants and capabilities passed\n";return 0;
}catch(const std::exception &e){std::cerr<<e.what()<<'\n';return 1;}