Manage real OBS careers in native save and load dialogs (by Codex)

This commit is contained in:
Codex committed 2026-10-29 02:57:32 +01:00
1 parent 693744a961
commit e3ea03a05d
25 files changed
+539 -39

No files matched your search

+20 -1
View File
@@ -1,6 +1,8 @@
// SPDX-License-Identifier: GPL-3.0-only
// Opt-in private-data probe. Never registered as an unconditional CTest.
#include "modern/ui/engine_bridge.hpp"
#include "modern/ui/career_files.hpp"
#include "content/package.hpp"
#include "modern/app/modern_session.hpp"
#include "modern/content/world_package.hpp"
#include "modern/ui/demo_opening.hpp"
@@ -13,7 +15,7 @@ using namespace bmh::modern_ui;
int main(int argc, char **argv) {
try {
const std::string mode=argc>1?argv[1]:"";
const std::set<std::string> modes{"prepare","prepare-two","prepare-national","prepare-almanac","inspect","inspect-friendlies","inspect-almanac","verify","verify-lineup","verify-sports","verify-bank","verify-commerce","verify-contracts","verify-calendar","verify-friendlies","verify-national","verify-almanac","verify-shootouts","verify-reports","verify-fixtures","verify-other","verify-rankings","prepare-rankings-archived","verify-create","inspect-coach-identity","prepare-coach-identity","verify-coach-almanac"};
const std::set<std::string> modes{"prepare","prepare-two","prepare-national","prepare-almanac","inspect","inspect-friendlies","inspect-almanac","verify","verify-lineup","verify-sports","verify-bank","verify-commerce","verify-contracts","verify-calendar","verify-friendlies","verify-national","verify-almanac","verify-shootouts","verify-reports","verify-fixtures","verify-other","verify-rankings","prepare-rankings-archived","verify-create","inspect-coach-identity","prepare-coach-identity","verify-coach-almanac","verify-files"};
if(argc!=4||!modes.contains(mode))throw std::runtime_error("usage: modern_engine_bridge_probe <prepare[-two|-national|-almanac]|inspect[-friendlies|-almanac]|verify[-lineup|-sports|-bank|-commerce|-contracts|-calendar|-friendlies|-national|-almanac|-shootouts]> <world.obw> <new-output-directory>");
const fs::path world = argv[2], out = argv[3]; fs::create_directories(out);
const auto write = [&](const char *file, const Json &j) { editor::write_atomic(out / file, j.dump(2)); };
@@ -128,6 +130,23 @@ int main(int argc, char **argv) {
auto link = EngineBridge::open(world, out / "input.obs");
const auto before = link->snapshot(); write("before.json", before);
if (before != link->snapshot()) throw std::runtime_error("reads changed the engine projection");
if(mode=="verify-files") {
auto store=make_career_files(out/"library",world);const auto meta=link->file_metadata();write("metadata.json",meta);
const auto first=store.put("Erste Saison",[&](const auto &path){link->save_copy(path);});
if(first.data!=meta||link->snapshot()!=before)throw std::runtime_error("save/list changed state or metadata");
// A real command changes revision; loading the saved copy must restore the earlier career.
const auto current=engine_money_minor(before.at("stadium").at("data").at("ticketPrice"))/100;
const auto request=engine_ticket_command(before,int(current==20?21:20),"request:file-change");
const auto response=link->command(request);write("changed-response.json",response);if(response.value("messageType","")!="command_result")throw std::runtime_error(response.dump());
link->load_same_world(store.file(first.id),first.token);if(link->snapshot()!=before)throw std::runtime_error("staged load failed to restore snapshot");
store.export_file(first.id,first.token,out/"export.obs");const auto imported=store.import_file(out/"export.obs");if(imported.data!=first.data)throw std::runtime_error("real OBS import metadata differs");
editor::write_atomic(out/"damaged.obs","damaged");
auto documents=content::read_archive(store.file(first.id));auto driver=Json::parse(documents.at("state/driver.json"));driver["schema"]="invalid-driver";documents["state/driver.json"]=driver.dump();auto integrity=Json::parse(documents.at("state/integrity.json"));integrity["entries"]["state/driver.json"]=content::sha256(documents.at("state/driver.json"));documents["state/integrity.json"]=integrity.dump();content::write_archive(documents,out/"bad-driver.obs",false);
Json rejected=Json::array();for(const auto *file:{"damaged.obs","bad-driver.obs"}){bool caught=false;try{link->load_same_world(out/file);}catch(const std::exception &e){caught=true;rejected.push_back({{"file",file},{"error",e.what()}});}if(!caught||link->snapshot()!=before)throw std::runtime_error("rejected load damaged old session");}
// A command after the failed staged constructor catches leaked process-global layout state.
const auto after=link->command(request);if(after.value("messageType","")!="command_result")throw std::runtime_error("old session no longer usable after failed load");
write("rejected.json",rejected);write("after-failures.json",link->snapshot());write("receipt.json",{{"status","passed"},{"realObsRoundTrip",true},{"failedLoadPreservesSession",true},{"metadataReadOnly",true}});std::cout<<"real OBS file library and staged load failure preservation passed\n";return 0;
}
if (std::string(argv[1]) == "inspect-friendlies") {
const auto &opponents=before.at("friendly-plan").at("data").at("opponents");
if(opponents.empty())throw std::runtime_error("no friendly opponents");