Add editor browser navigation, idle rendering and Modern pickers (by Codex)
OBW Editor / editor (linux-x64, ubuntu-24.04) (push) Canceled after 0s
OBW Editor / editor (macos-arm64, macos-14) (push) Canceled after 0s
OBW Editor / editor (windows-x64, windows-2022) (push) Canceled after 0s
OBW Editor / release (push) Canceled after 0s

This commit is contained in:
Codex committed 2026-10-23 13:48:32 +02:00
1 parent 245e213cca
commit fe307dea41
21 files changed
+648 -47

No files matched your search

+14
View File
@@ -48,6 +48,7 @@ int main() {
try {
Session s;
s.execute("demo");
const auto generation = s.execute("info")["world_generation"];
check(s.execute("list", {{"table", "players"}})["total"] == 52, "all squads retained");
check(s.execute("list", {{"table", "players"}, {"team", "club:north"}, {"limit", 24}})["items"].size() == 24,
"24 view");
@@ -63,6 +64,8 @@ int main() {
s.execute("undo");
check(row(s, "players", "player:demo-0") == initial, "undo complete row");
check(s.execute("info")["revision"] > revision, "revision monotonic across undo");
check(s.execute("info")["world_generation"] == generation,
"edits and undo keep navigation world identity");
s.execute("redo");
check(row(s, "players", "player:demo-0")["attributes"]["strength"] == 99, "redo");
rejects("validation_failed",
@@ -233,6 +236,17 @@ int main() {
}
#endif
check(tr("de", "clubs") != tr("en", "clubs"), "bilingual labels");
{
Session reopened;
reopened.execute("demo");
const auto identity = reopened.execute("info")["world_generation"];
reopened.execute("save", {{"path", utf8(root / "navigation-world.obw")}});
check(reopened.execute("info")["world_generation"] == identity,
"saving keeps navigation world identity");
reopened.execute("open", {{"path", utf8(root / "navigation-world.obw")}});
check(reopened.execute("info")["world_generation"] > identity,
"reopening identical IDs resets navigation identity");
}
McpServer mcp(s);
mcp.start(options);
httplib::Client client("127.0.0.1", mcp.port());
+94 -1
View File
@@ -209,7 +209,100 @@ def main():
before_view = tool('editor_info')
click(1100, 326); x('key', 'Escape'); time.sleep(.2)
assert tool('editor_info') == before_view
print('Native edit, comparisons, rules, drill-down, read-only image preview and asset links passed.')
# Browser navigation restores the selected league and its
# filters without editing data or advancing the undo cursor.
def history(direction):
before = tool('editor_info')
x('mousemove', '--window', window, 760, 300, 'click', 3)
time.sleep(.15)
click(850, 330 if direction == 'back' else 375)
time.sleep(.2)
assert tool('editor_info') == before, 'History must be read only'
click(100, 264); double_click(350, 385)
double_click(350, 335)
history('back')
edit_selected('clubs', 'club:south', 'History Team')
history('back')
edit_selected('competitions', 'comp:second', 'History League')
history('forward')
edit_selected('clubs', 'club:south', 'History Forward Team')
history('forward')
edit_selected('players', south_player, 'History Forward Player', True)
# Cancelling a pending property edit must keep the history
# cursor in place, so the next Back still visits the team.
click(1150, 443); x('key', 'ctrl+a'); x('type', '--clearmodifiers', 'History Draft')
history('back'); x('key', 'Escape'); time.sleep(.2)
click(1300, 741)
assert tool('editor_get', {'table': 'players', 'id': south_player})['record']['name']['first'] == 'History Draft'
tool('editor_undo'); time.sleep(.5)
history('back')
edit_selected('clubs', 'club:south', 'History After Cancel')
# A different destination after Back removes the forward
# branch. Alt+arrows and mouse side buttons share this history.
click(100, 313)
x('key', 'alt+Right'); time.sleep(.2)
edit_selected('clubs', 'club:north', 'History New Branch')
x('click', 8); time.sleep(.3)
edit_selected('clubs', 'club:south', 'History Side Back')
x('click', 9); time.sleep(.3)
edit_selected('clubs', 'club:north', 'History Side Forward')
# Preview -> exact asset is also a visit, not a data undo.
click(280, 385); click(985, 757)
history('back')
edit_selected('clubs', 'club:north', 'History Preview Back')
history('forward')
edit_selected('assets', 'asset:demo/south', 'History Preview Forward')
# External MCP opens invalidate navigation, including when the
# filename and all record IDs are unchanged.
click(100, 361); click(100, 313)
generation = tool('editor_info')['world_generation']
tool('editor_open', {'path': str(root / 'world.obw'), 'discard': True})
time.sleep(.6)
assert tool('editor_info')['world_generation'] > generation
x('key', 'alt+Left'); time.sleep(.2)
edit_selected('clubs', 'club:north', 'History New World')
# Modern dropdowns retain native values and keyboard input.
# Escape cancels just the open list, keeping Options open and
# restoring its prior value. Nothing applies before Apply.
before_options = tool('editor_info')
click(1370, 44)
click(690, 258); x('key', 'Down'); x('key', 'Escape')
time.sleep(.15)
assert json.loads(settings.read_text())['language'] == 'de'
click(690, 343); x('key', 'Down'); x('key', 'Return')
assert json.loads(settings.read_text())['theme'] == 'midnight'
click(950, 725)
assert json.loads(settings.read_text())['theme'] == 'silver'
assert json.loads(settings.read_text())['language'] == 'de'
click(1370, 44)
click(690, 258); x('key', 'Down'); x('key', 'Return')
click(690, 343); x('key', 'Down'); x('key', 'Return')
click(950, 725)
assert json.loads(settings.read_text())['theme'] == 'matchday'
assert json.loads(settings.read_text())['language'] == 'en'
click(1370, 44)
click(690, 258); x('key', 'Up'); x('key', 'Return')
click(690, 343); x('key', 'Up'); x('key', 'Up'); x('key', 'Return')
click(950, 725)
assert json.loads(settings.read_text())['theme'] == 'midnight'
assert json.loads(settings.read_text())['language'] == 'de'
assert tool('editor_info') == before_options
# An idle, unfocused form must not continuously render. The
# generous one-core CPU budget catches a software-render loop
# while allowing timer/MCP polling and slow CI machines.
click(700, 153); time.sleep(.5)
def cpu_seconds():
fields = Path(f'/proc/{app.pid}/stat').read_text().rsplit(')', 1)[1].split()
return (int(fields[11]) + int(fields[12])) / os.sysconf('SC_CLK_TCK')
before_idle = tool('editor_info')
cpu_start, wall_start = cpu_seconds(), time.monotonic()
time.sleep(3)
cpu_used, wall_used = cpu_seconds() - cpu_start, time.monotonic() - wall_start
assert cpu_used < .20 * wall_used, f'Idle CPU exceeded 20% of one core: {cpu_used / wall_used:.1%}'
assert tool('editor_info') == before_idle
assert 'Syntax error parsing property' not in (root / 'app.log').read_text()
print(f'Idle CPU: {cpu_used / wall_used:.1%} of one core.')
print('Native edits, comparisons, rules, drill-down, image previews, browser history and idle CPU passed.')
except Exception:
log.flush()
print((root / 'app.log').read_text())