career_session.cpp (9,000 lines) is now eight files: construction and turn,
club dialogs, league family, statistics, transfers, desk, match, management.
Every function moved unchanged. Helpers used by one topic live in its file,
the seven shared ones in the internal header career_session_internal.hpp.
Co-Authored-By: Claude <noreply@anthropic.com>
WorldLayout names the dimensions of a game world (league clubs, amateurs,
foreign cup clubs, the pseudo team, national teams, squad slots and pools).
classic_world_layout() holds the numbers of the original; squad_range() and
team_average() ask it instead of literals. A test compares squad_range() with
the former arithmetic for every team id and checks that inconsistent layouts
are refused.
Co-Authored-By: Claude <noreply@anthropic.com>
On a file system that ignores case the viewer (target openbmh) and the game
(OpenBMH, target openbmh_play) were the same file in the build directory, and
whichever was linked last replaced the other.
Co-Authored-By: Claude <noreply@anthropic.com>
struct App moves out of main.cpp into app/app.hpp (state and declarations;
the return types are spelled out now, taken from the compiler) and its 94
member functions into
app_run.cpp handle() and run(): wiring, title screen, event loop
app_live.cpp live match, interventions, event animations, reality mode
app_transfer.cpp offers, decisions, market sales, loan returns, poaching
app_season.cpp season end and start: tax, promotion, highscore, cup draw
app_services.cpp timers and deadlines served between inputs
app_club.cpp the club dialogs
app_sportschau.cpp the Sportschau
app_notices.cpp notices and questions over a screen
main.cpp keeps main(): game data, window, sound (238 lines instead of 4,550).
The function bodies moved unchanged. docs/DIFFERENCES.md is regenerated (a
marker moved to app_run.cpp).
Verified: 211 of 211 tests; careers, UI walk and robot (234 commands)
identical; long robot run (52 kick-offs to April of the season, indoor
tournament included): every desk picture identical.
Co-Authored-By: Claude <noreply@anthropic.com>
- json_quote, original_to_utf8 and utf8_to_original lived in ui/manager, the
manager dialog, although every screen, the console client and the app use
them. They move byte for byte to formats/text_encoding (namespace bmh);
ui/manager.hpp keeps them visible as bmh::ui::... .
- The app sources (career session, window/desktop actions, controller) are
object libraries on MSVC too, compiled with /utf-8 like the game. Before,
the MSVC build compiled the 9,000 line career_session.cpp again for each of
about forty tests and tools.
Verified: 211 of 211 tests; 9 headless careers identical; the UI walk
differs only on the stadium screen, as expected from the 96,000 place
limits merged from main (reference re-recorded).
Co-Authored-By: Claude <noreply@anthropic.com>
- game/digest: fingerprint of the whole game state (saved stream, unsaved
run-time values, both random generators)
- season_sim: SIM_DIGEST=<file> writes one digest per desk; SIM_LEAGUE picks
the start league
- tools/ci/compare_digests.py compares two directories of digest files
- ui_walk (tool): replays an input script against the UI flow and the
production controller without a window, one picture/state fingerprint per step
- openbmh_ui --frames: the same fingerprints for its scripted mode
No change of game behaviour. Reference files live outside the repository.
Co-Authored-By: Claude <noreply@anthropic.com>
The numbers of the Diamond 3.7 executable and of Football Limited stay built in,
the game texts go into data/openbmh.dat, which the release ships next to the
programs (found in OPENBMH_DAT, the game folder, the program folder, the current
folder). Without the file those texts are empty. A replay of a recorded session
gives the same output as with the real BMH.exe when the file is there, and differs
only in the seven text lines when it is missing. week_check no longer counts its
probe re-rating of the team as draws of the port (the apparent deviation from
minute 10 of the DOSBox recording was this measuring error).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The game no longer needs BMH.EXE or FLTD.EXE. The numbers and the game texts of
the Diamond 3.7 executable and of the English Football Limited are generated into
formats/diamond_constants.inc and formats/fltd_constants.inc (tools/diamond_constants).
A missing BMH.exe loads the embedded German image, an English installation without
FLTD.EXE gets the embedded English image; an executable that is present is used as
before. The default manager name is OpenBMH. The launcher accepts directories and
archives that hold only the asset files. Replays of a recorded session give identical
output with and without BMH.EXE, and the English image equals the translated one.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The release asset download returned HTTP 504 for hours and blocked the Windows
build. miniz (MIT) is two source files, so it now lives in third_party/miniz and
the public-tree check skips that unmodified third-party directory.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
New game/search_profile.* holds the 18-byte search profile of a human manager (manager record
+0x1f6): the dialog's closing rule, the suggestion generated from the squad (original sub_18F06),
the position strengths (sub_19A38) and the listing match (sub_190B5). search_profile_news in
month.cpp now uses the same matching rule. Compared with the Diamond 3.7 routines in the
emulator harness on 10 savegames (306 runs, 406 matched listings, no difference; a deliberately
changed profile is detected).
Part of #79 (the dialog in the graphical client and the console commands follow)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Use 64-bit products in actual monthly fund/property settlement, monthly and annual previews, and weekly dividend offers. Retain per-unit rounding, recipient policy and final native fields. Test representable high-value settlements against their forecasts. Full 32-bit money storage overflow remains unresolved.
Refs: #46
Route window-close events, animation polls, Escape and desktop exit through a native confirmation with Cancel selected by default. Preserve the current owner when cancelled. Refs #11.