92 comparisons against the raw numbers 138, 168 and 357 in engine, UI and app
read world_layout().league_teams, first_foreign_cup() and no_team(); a team id
written as 0x165 is kNoTeam. Same values, same arithmetic.
Co-Authored-By: Claude <noreply@anthropic.com>
Every source file in ui, app, game, formats, cli, audio and launch that had none
now starts with a short English comment: what it implements, what state it owns
and how it relates to its neighbours (request/acknowledge flow, pairs of files,
random generator use). Comment lines only; the full build and the runnable
tests are unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Desktop: the opponent's badge sheet was loaded once when the screen
was built and kept while the state advanced, so the index of the new
opponent picked a badge from the old sheet (a foreign club's logo, the
wrong club for RB Leipzig). It is reloaded with every new state.
- National desk: the desk keeps the home club's key per manager (for
the hand-back), while Table, Stärken, Other games and the other pages
carry the identity of the runtime club (the national team). The
controller and flow compared the two and refused ("invalid Table
dispatch manager identity", "stale desktop identity"). DeskState now
gives session_identity_key() and the comparisons use it.
Refs #74.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Loading: a single-manager desk saved with DeskPosition == ManagerCount
(the completed loop) is read as the first desk again instead of being
refused as "not a savegame".
- Calendar: text takes the original's six-row colour gradient (the flat
colours were too dark next to the original).
- Pointer: sized in window points, so it is not doubled on Retina screens.
- Settings: the page names OpenBMH and shows the build version below.
- Desk: the opponent's badge is shown whenever the data has one
(documented difference); cup-only teams keep the computer portrait.
- Live overview tests: Tabelle/Stärken/Spiele handovers, also with the
Spiele page opened first.
- New command line option -debug: timestamped log, stderr captured in a
file, and a savegame after every match day in <saves>/debug.
Refs #63, #65, #67, #68, #71, #73.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>