67 file-local helpers (fill/rect/copy/copy_region/... in 39 screens) now call
draw::fill, draw::copy_clipped or draw::copy_unclipped. Only the loops moved:
every screen keeps its own wrapper with its bounds check and error text, so
the contracts are unchanged. Eight helpers with special behaviour stay as
they are (bank, season promotion, toto, tax animation, ...).
Verified: 9 headless careers and the scripted UI walk (German and English
data, 38 screens, about 5,460 steps each) give the same fingerprints as
before. ctest: 209 of 211; other_games_ui_tests and ui_preparation_tests
fail the same way without this change.
Co-Authored-By: Claude <noreply@anthropic.com>
Transfer market, pitch, lineup, bank, offer editor, advertising, manager, player card,
player detail, club info, league pairings, other games, top scorers, stadium,
training, game end and the contract tabs drew the same button frame with their own
copies. They now call draw_wide_button_frame (ui/button_frame.hpp), which a test
compares pixel for pixel with the former drawing. Buttons whose drawing differs by a
pixel (statistics rankings, team statistics, opportunities, analytics) are left alone.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bank (stocks, property, savings, credit), the offer editor footer, the lineup
bottom buttons and the pitch page buttons Daten and Kurz are drawn in the
pressed look from the mouse press until the release, like the friendly match
question. The frame drawing is shared in ui/button_frame.hpp.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Every source file in ui, app, game, formats, cli, audio and launch that had none
now starts with a short English comment: what it implements, what state it owns
and how it relates to its neighbours (request/acknowledge flow, pairs of files,
random generator use). Comment lines only; the full build and the runnable
tests are unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The live lineup of a national-team match failed with 'pitch: unsupported club'
because the pitch extras only accepted league club ids. The national desk
(runtime club 357, national squad pool) is now accepted under the same
condition as the lineup page, uses badge sheet 0 and its own roster base for
the marking lookup.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Settings: every unlocked switch is stored, as in the original; the
whitelist of cells with a consumer is gone (J9, O3, ... no longer
refused). Locks and 0/1 / numeric limits still apply.
- Training: the seven skill bars show the player row under the pointer
(FUN_00049399).
- Line-up: the field stays editable inside the set-piece editor while no
taker kind is chosen.
- Pointer: the original 11x11 bitmap is the default pointer on every
page, not only on the pitch page.
Refs #57, #59, #60, #62.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Hold scoreboard digits through chance animations, retain overview gesture ownership through moved releases, and restore original affinity swatches and colored pointer from each edition. Preserve simulation and RNG boundaries; cover source observer and UI projections.
Refs: #43, #44, #45
Address UI reports #1–#4: preserve the native live pitch page, acknowledge page controls on press, restore original instruction sprites and coverage, and allow file dialog cancellation and filename replacement. Keep graphical comparisons and save evidence in the private reference repository.