Describe original routines in comments instead of naming them
The public-source check rejects decompiler symbol names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
af634ae8ff
commit
1e7df751a0
4 files changed
+4
-4
No files matched your search
+1
-1
@@ -230,7 +230,7 @@ int main(int argc, char** argv) {
|
|||||||
english_game = english_game || season_exe.u8(layout::LeagueSizes) == 20;
|
english_game = english_game || season_exe.u8(layout::LeagueSizes) == 20;
|
||||||
{
|
{
|
||||||
// The pointer of the original is its default 11x11 bitmap (index 0 transparent, hot spot
|
// The pointer of the original is its default 11x11 bitmap (index 0 transparent, hot spot
|
||||||
// top left, set by the window objects' FUN_000559eb); the pitch page draws the same bitmap
|
// top left, set when a window object is created); the pitch page draws the same bitmap
|
||||||
// with its own fill colour. The edition's own bitmap is used for the English version.
|
// with its own fill colour. The edition's own bitmap is used for the English version.
|
||||||
std::array<uint32_t, 121> bitmap{};
|
std::array<uint32_t, 121> bitmap{};
|
||||||
for (uint32_t i = 0; i < bitmap.size(); ++i) {
|
for (uint32_t i = 0; i < bitmap.size(); ++i) {
|
||||||
|
|||||||
+1
-1
@@ -250,7 +250,7 @@ Image TrainingScreen::render() const {
|
|||||||
}
|
}
|
||||||
rect(out, 190, 222, 66, 6, 0x44);
|
rect(out, 190, 222, 66, 6, 0x44);
|
||||||
text(out, 190, 220, texts_[(::bmh::layout::Training_Render_TextPointer4 - ::bmh::layout::TextPointerTable) / 4], 0x51, -1, false);
|
text(out, 190, 220, texts_[(::bmh::layout::Training_Render_TextPointer4 - ::bmh::layout::TextPointerTable) / 4], 0x51, -1, false);
|
||||||
// FUN_00049399: seven bars, one per skill (two bits each of the player's skill word); each
|
// The original's skill display: seven bars, one per skill (two bits each of the player's skill word); each
|
||||||
// takes the atlas tile of its level 0-3, all empty while no player's row is under the pointer.
|
// takes the atlas tile of its level 0-3, all empty while no player's row is under the pointer.
|
||||||
const auto hovered = hovered_row_ ? std::find_if(state_.players.begin(), state_.players.end(),
|
const auto hovered = hovered_row_ ? std::find_if(state_.players.begin(), state_.players.end(),
|
||||||
[&](const auto& p) { return p.row == *hovered_row_; })
|
[&](const auto& p) { return p.row == *hovered_row_; })
|
||||||
|
|||||||
+1
-1
@@ -54,7 +54,7 @@ public:
|
|||||||
Image render() const;
|
Image render() const;
|
||||||
TrainingRequest click(int x, int y, bool right = false);
|
TrainingRequest click(int x, int y, bool right = false);
|
||||||
TrainingRequest key(std::string_view key);
|
TrainingRequest key(std::string_view key);
|
||||||
// Original FUN_00049399: while the pointer rests on a player's row of the training list, the
|
// The original's skill display: while the pointer rests on a player's row of the training list, the
|
||||||
// seven skill bars (T S S P Z F E) at the bottom show that player's skills; leaving it clears them.
|
// seven skill bars (T S S P Z F E) at the bottom show that player's skills; leaving it clears them.
|
||||||
bool move(int x, int y);
|
bool move(int x, int y);
|
||||||
// Opening an uninitialized original screen invokes Initialize. This
|
// Opening an uninitialized original screen invokes Initialize. This
|
||||||
|
|||||||
@@ -67,7 +67,7 @@ int main(int argc, char** argv) {
|
|||||||
TrainingScreen screen(data, s); const auto frame = screen.render().pixels;
|
TrainingScreen screen(data, s); const auto frame = screen.render().pixels;
|
||||||
check(frame == screen.render().pixels, "repeat rendering is deterministic and pure");
|
check(frame == screen.render().pixels, "repeat rendering is deterministic and pure");
|
||||||
{
|
{
|
||||||
// FUN_00049399: the seven skill bars follow the player row under the pointer
|
// the seven skill bars follow the player row under the pointer
|
||||||
const int bx = exe.u16(::bmh::layout::Training_Click_RuntimeField + 6), by = exe.u8(::bmh::layout::Training_Click_RuntimeField3 + 3);
|
const int bx = exe.u16(::bmh::layout::Training_Click_RuntimeField + 6), by = exe.u8(::bmh::layout::Training_Click_RuntimeField3 + 3);
|
||||||
const int dy = exe.u8(::bmh::layout::Training_Click_RuntimeField9 + 3);
|
const int dy = exe.u8(::bmh::layout::Training_Click_RuntimeField9 + 3);
|
||||||
TrainingScreen hover(data, s);
|
TrainingScreen hover(data, s);
|
||||||
|
|||||||
Reference in new issue
Block a user