App::handle: the presenters passed to the controller are named members
handle() was 1,628 lines: the call of serve_flow_request with 22 presenter lambdas written inline. They are member functions now (present_live_minute, observe_live_minute, animate_ball / chance / shot / set_piece / booking / shootout, present_reality, choose_transfer_offer, present_transfer_decision, present_season_checkpoint, show_club_information, ask_advertising_renewal, ask_national_friendly, ...), as are its two local helpers (present_live_lineup, present_running_overview). handle() keeps 111 lines. handle() is never re-entered (its callers are the service functions and run(), none of which is reached from inside it), so its ten locals became members that handle() resets where they were declared. The bodies moved unchanged. Verified: robot (234 commands, live match included), UI walk, 9 careers identical; 211 of 211 tests. Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
1 parent
71aeb7cc61
commit
99200f1dc8
1 file changed
+1632
-1549
+1632
-1549
File diff suppressed because it is too large.
Load diff
Reference in new issue
Block a user