other_games_ui_tests and ui_preparation_tests still expected "Nobody"; the
manager dialog offers "OpenBMH", so the attachment check rejected the fixture.
Co-Authored-By: Claude <noreply@anthropic.com>
The extension to 144,000 places of 1.0.3 is withdrawn: the match broadcast of
the original has no room for attendances of 100,000 and more and showed them
wrongly. Limits, unit prices and construction weeks now come from the edition
unchanged (3.7: 8/18/8/14 thousand per block, 30/37/30/25 weeks). A savegame
with a larger stadium keeps its places but cannot extend such a block further.
Co-Authored-By: Claude <noreply@anthropic.com>
- game/digest: fingerprint of the whole game state (saved stream, unsaved
run-time values, both random generators)
- season_sim: SIM_DIGEST=<file> writes one digest per desk; SIM_LEAGUE picks
the start league
- tools/ci/compare_digests.py compares two directories of digest files
- ui_walk (tool): replays an input script against the UI flow and the
production controller without a window, one picture/state fingerprint per step
- openbmh_ui --frames: the same fingerprints for its scripted mode
No change of game behaviour. Reference files live outside the repository.
Co-Authored-By: Claude <noreply@anthropic.com>
The six side strengths of an indoor round depend on the chance weather kept
from the last chance of the round before (a runtime value the savegame does
not hold). With WEEK_PREV_WEATHER the kick-off of all eleven recorded rounds
equals the real 3.7. week_check gets that switch plus development helpers for
weather, line-up and formation table; the measurement document is updated.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Assets with openbmh.dat are a complete game; without that file the launcher asks
for BMH.EXE (FLTD.EXE) as before. With both present the executable is used.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The numbers of the Diamond 3.7 executable and of Football Limited stay built in,
the game texts go into data/openbmh.dat, which the release ships next to the
programs (found in OPENBMH_DAT, the game folder, the program folder, the current
folder). Without the file those texts are empty. A replay of a recorded session
gives the same output as with the real BMH.exe when the file is there, and differs
only in the seven text lines when it is missing. week_check no longer counts its
probe re-rating of the team as draws of the port (the apparent deviation from
minute 10 of the DOSBox recording was this measuring error).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The game no longer needs BMH.EXE or FLTD.EXE. The numbers and the game texts of
the Diamond 3.7 executable and of the English Football Limited are generated into
formats/diamond_constants.inc and formats/fltd_constants.inc (tools/diamond_constants).
A missing BMH.exe loads the embedded German image, an English installation without
FLTD.EXE gets the embedded English image; an executable that is present is used as
before. The default manager name is OpenBMH. The launcher accepts directories and
archives that hold only the asset files. Replays of a recorded session give identical
output with and without BMH.EXE, and the English image equals the translated one.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
VERKAUFEN on a player who stands on the transfer list only showed a message
when no offer had arrived yet. The original first asks whether the player
should be taken off the transfer market: yes frees the list slot (the player
stays in the squad), no continues to the offers. Controller and UI tests cover
both answers.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- The notice dialog refused Source notices it did not know, which silently refused the whole action: the agreement of a
poached player ("Ihr erstes Angebot wird angenommen!") made the Angebot button of the Abwerben dialog fail, and the new
search boxes never appeared. Both text families are known now; the test turns every notice of the transfer routes into
its dialog like the graphical client does.
- Suchen/Vorschlag/Abwerben and the other market buttons are drawn pressed while the mouse button is held.
- Confirming the search dialog first reports "Ihre Scouting-Abteilung ..." (text 0xAF25C) as in the original, then the matches.
- A refused transfer or offer action shows its reason, writes it to stderr and the debug log.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
TransferMarketScreen gets the dialog of the original (KB/69.VGA panel at 184,20, seven bar rows from the
EXE table, click rules of sub_19409, confirm button, price estimate). Suchen opens it with the stored
profile, Vorschlag with the suggestion the squad asks for (computed in the projection). Closing posts a
store_search_profile request; the controller stores it and announces the matching listings through the
notice presenter, like the original's message boxes. Right button or Esc leaves with the search switched
off. Controller test drives the whole route.
The market list showed the asking fee scaled by 0x30d4 (older Diamond); 3.7 rounds to 10000
(sub_3C940), now also in the projection. Four tests computed the old base and follow.
Fixes#79
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Two controller tests: an own listing with a bid is reviewed from the roster, the offers reach the
presenter and accepting sells the player; a listing that expires with a declined offer leaves the
list and the player can be listed again from the roster. Both pass; the reported "cannot review
offers / cannot list again" could not be reproduced on this route. app_controller_tests gets a
--market-only switch.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CareerSession gets search_profile, suggest_search_profile and dispatch_search_profile (owner and
modal-state checks, revision only when the stored profile changed). The console replaces the
OpenSearch placeholder with three commands and documents them; with apply the matching listings
are reported with the original's "Spieler ... ist interessant!" message. search_profile_valid
separates a refused profile from a switched-off one.
Part of #79 (the dialog in the graphical client is still open)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
New game/search_profile.* holds the 18-byte search profile of a human manager (manager record
+0x1f6): the dialog's closing rule, the suggestion generated from the squad (original sub_18F06),
the position strengths (sub_19A38) and the listing match (sub_190B5). search_profile_news in
month.cpp now uses the same matching rule. Compared with the Diamond 3.7 routines in the
emulator harness on 10 savegames (306 runs, 406 matched listings, no difference; a deliberately
changed profile is detected).
Part of #79 (the dialog in the graphical client and the console commands follow)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Injury chance 1 in 31 (was 1 in 39), no-booking roll W(0,3), straight red 1 in 34
(was 1 in 28), the injury type thresholds (match injuries now types 3-30), the
duration table, 1/4 longer for a player injured before (was 1/8) and the club
doctor's cut (/8, capped only for the heavy types 20-30). Values read from the
3.7 programme, measured against the earlier build the engine was derived from.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Found with the debug log and savegames of a real session:
- Calendar: it read the memory copies of the season origin and day,
which hold only the day the game was loaded or saved, and refused
from the first kickoff on ("saved native season cursor disagrees").
It now uses the live values, as the reschedule code does. This also
fixes "Spiel verlegen".
- Stärken: the guard of dispatch_strengths required a desk stage, but
the turn driver marks the running turn as Failed (replay guard) for
its whole duration, so Stärken could never open from the live
overview or the end-of-phase results page; the failed handover then
left the other pages with stale owners and the match stuck. The
guard now accepts the running turn while a live overview is open.
- Tests: calendar after a kickoff; live overview handovers on the
phase results page.
Refs #71, #73.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- The Von/Bis calculator of the league table is left with the right
mouse button (as the Toto calculator), restoring the backdrop.
- The stadium panorama draws no hover frame (the original draws none);
the yellow frames stay on the main page (seat blocks, investments).
Refs #64, #66.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
As on the advertising page, the target under the pointer gets a yellow
frame: a finished seat block and an available investment icon on the
main page, and the hit rectangle of a building in the panorama (next to
its information panel). The frame appears only where a click acts.
Refs #64.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Loading: a single-manager desk saved with DeskPosition == ManagerCount
(the completed loop) is read as the first desk again instead of being
refused as "not a savegame".
- Calendar: text takes the original's six-row colour gradient (the flat
colours were too dark next to the original).
- Pointer: sized in window points, so it is not doubled on Retina screens.
- Settings: the page names OpenBMH and shows the build version below.
- Desk: the opponent's badge is shown whenever the data has one
(documented difference); cup-only teams keep the computer portrait.
- Live overview tests: Tabelle/Stärken/Spiele handovers, also with the
Spiele page opened first.
- New command line option -debug: timestamped log, stderr captured in a
file, and a savegame after every match day in <saves>/debug.
Refs #63, #65, #67, #68, #71, #73.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Settings: every unlocked switch is stored, as in the original; the
whitelist of cells with a consumer is gone (J9, O3, ... no longer
refused). Locks and 0/1 / numeric limits still apply.
- Training: the seven skill bars show the player row under the pointer
(FUN_00049399).
- Line-up: the field stays editable inside the set-piece editor while no
taker kind is chosen.
- Pointer: the original 11x11 bitmap is the default pointer on every
page, not only on the pitch page.
Refs #57, #59, #60, #62.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Use 64-bit products in actual monthly fund/property settlement, monthly and annual previews, and weekly dividend offers. Retain per-unit rounding, recipient policy and final native fields. Test representable high-value settlements against their forecasts. Full 32-bit money storage overflow remains unresolved.
Refs: #46
Hold scoreboard digits through chance animations, retain overview gesture ownership through moved releases, and restore original affinity swatches and colored pointer from each edition. Preserve simulation and RNG boundaries; cover source observer and UI projections.
Refs: #43, #44, #45