The engine asks the selling manager and the buyer a yes/no question when a poaching offer
is decided (hooks.confirm). The graphical client only supplied the notice presenter, so the
engine refused the offer, the controller swallowed the reason and the ANGEBOT button appeared
to do nothing. The client now shows the question with the existing yes/no dialog.
Fixes#80
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Strength of the new player is the youth-team strength setting, the academy is
skipped when the squad's youth average is more than 25 above it, up to two rounds
need W(0, 3) == 0, and the retirement/retire rules use the 3.7 slot range. The
age test was inverted: only a player older than the roll W(t, t + 3) is recycled
(found by comparing with the 3.7 programme in an emulator, 192 runs on whole
savegames, no difference). Removes the old strength-band deviation entries.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kFacilityValue (entries 1, 2, 5), the per-visitor facility income table and the
season-ticket price of the first division. Checked against the 3.7 programme in
an emulator on whole savegames: weekly statistics now match without difference.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Credit limit 8 million, fee base 10000 per 10000 of value, DFB fee 150 %,
championship bonus 700000, club-popularity premiums 400000/850000/1000000/850000,
periphery prices, advertising base 0x87, start capital step 3 million, the
broke limit -4 million, the training-injury chance, retirement after an injury
of more than 20 matchdays (1 in 40), the contract-talk limit and the side
rhythm (human: no balance term, computers: at least 48). Values read from the
3.7 programme; the earlier build the engine was derived from used other numbers.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Injury chance 1 in 31 (was 1 in 39), no-booking roll W(0,3), straight red 1 in 34
(was 1 in 28), the injury type thresholds (match injuries now types 3-30), the
duration table, 1/4 longer for a player injured before (was 1/8) and the club
doctor's cut (/8, capped only for the heavy types 20-30). Values read from the
3.7 programme, measured against the earlier build the engine was derived from.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Function and section comments for ui/stadium, ui/preparation_flow, the
transfer market, contract, outgoing and incoming transfer screens, and for
app/main, app/window_actions and app/desktop_actions. Comment lines only;
full build and runnable tests unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Function and group comments for ui/flow, app/controller and app/career_session:
the request/acknowledge model, the revision and identity checks, staged copies
that are committed on success, and the national-coach desk identity. Comment
lines only; full build and runnable tests unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Every source file in ui, app, game, formats, cli, audio and launch that had none
now starts with a short English comment: what it implements, what state it owns
and how it relates to its neighbours (request/acknowledge flow, pairs of files,
random generator use). Comment lines only; the full build and the runnable
tests are unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The original computes ((base / 100) * den) / 100 with 64-bit-mantissa x87
steps and one final store to a double. The host long double is only 64 bits
wide on MSVC and Apple silicon, so the annuity differed by 1 for roughly 0.2 %
of realistic loans (1-60 million) there. The chain is now evaluated with
integers, identical on every platform. Verified against the original routine
in an emulator: 5684 term/principal combinations, no difference.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Both screens are identified by the home club in the session; the desktop
check compared against the desk's own runtime club identity after the earlier
Table/Strengths fix, so the national desk was rejected as stale.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The original shows only ABBRECHEN while a running sponsor contract is not
terminable; the button was always drawn here.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The live lineup of a national-team match failed with 'pitch: unsupported club'
because the pitch extras only accepted league club ids. The national desk
(runtime club 357, national squad pool) is now accepted under the same
condition as the lineup page, uses badge sheet 0 and its own roster base for
the marking lookup.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The table's club information (TeamInfo) enters the club again on each
redraw: view toggle, statistics, player card. The session required
exactly one entry and discarded the whole visit otherwise, also the
Nein/Radio/Video setting made in it, so a computer match could not be
set to Video. One entry is now the minimum.
Checked with a probe on a real savegame: table, club, two entries and
Video leave the category set.
Refs #75, #77.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Joining a manager: the next opponent of every manager is captured per
day for that day's manager count, so the joined manager's desk showed
"Spielfrei" until the next day was prepared. It is captured again when
the join is committed.
- The club player detail's atlas error now names the access and the
atlas size, so the debug log shows what failed.
Refs #76, #77.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Desktop: the opponent's badge sheet was loaded once when the screen
was built and kept while the state advanced, so the index of the new
opponent picked a badge from the old sheet (a foreign club's logo, the
wrong club for RB Leipzig). It is reloaded with every new state.
- National desk: the desk keeps the home club's key per manager (for
the hand-back), while Table, Stärken, Other games and the other pages
carry the identity of the runtime club (the national team). The
controller and flow compared the two and refused ("invalid Table
dispatch manager identity", "stale desktop identity"). DeskState now
gives session_identity_key() and the comparisons use it.
Refs #74.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Found with the debug log and savegames of a real session:
- Calendar: it read the memory copies of the season origin and day,
which hold only the day the game was loaded or saved, and refused
from the first kickoff on ("saved native season cursor disagrees").
It now uses the live values, as the reschedule code does. This also
fixes "Spiel verlegen".
- Stärken: the guard of dispatch_strengths required a desk stage, but
the turn driver marks the running turn as Failed (replay guard) for
its whole duration, so Stärken could never open from the live
overview or the end-of-phase results page; the failed handover then
left the other pages with stale owners and the match stuck. The
guard now accepts the running turn while a live overview is open.
- Tests: calendar after a kickoff; live overview handovers on the
phase results page.
Refs #71, #73.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- The Von/Bis calculator of the league table is left with the right
mouse button (as the Toto calculator), restoring the backdrop.
- The stadium panorama draws no hover frame (the original draws none);
the yellow frames stay on the main page (seat blocks, investments).
Refs #64, #66.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
As on the advertising page, the target under the pointer gets a yellow
frame: a finished seat block and an available investment icon on the
main page, and the hit rectangle of a building in the panorama (next to
its information panel). The frame appears only where a click acts.
Refs #64.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Loading: a single-manager desk saved with DeskPosition == ManagerCount
(the completed loop) is read as the first desk again instead of being
refused as "not a savegame".
- Calendar: text takes the original's six-row colour gradient (the flat
colours were too dark next to the original).
- Pointer: sized in window points, so it is not doubled on Retina screens.
- Settings: the page names OpenBMH and shows the build version below.
- Desk: the opponent's badge is shown whenever the data has one
(documented difference); cup-only teams keep the computer portrait.
- Live overview tests: Tabelle/Stärken/Spiele handovers, also with the
Spiele page opened first.
- New command line option -debug: timestamped log, stderr captured in a
file, and a savegame after every match day in <saves>/debug.
Refs #63, #65, #67, #68, #71, #73.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Settings: every unlocked switch is stored, as in the original; the
whitelist of cells with a consumer is gone (J9, O3, ... no longer
refused). Locks and 0/1 / numeric limits still apply.
- Training: the seven skill bars show the player row under the pointer
(FUN_00049399).
- Line-up: the field stays editable inside the set-piece editor while no
taker kind is chosen.
- Pointer: the original 11x11 bitmap is the default pointer on every
page, not only on the pitch page.
Refs #57, #59, #60, #62.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>